Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opengrm-ngram: init at 1.3.11, phonetisaurus: init at 2020-07-31 #94465

Merged
merged 2 commits into from Aug 1, 2020

Conversation

@Mic92
Copy link
Contributor

Mic92 commented Aug 1, 2020

Motivation for this change

This is a preparation for rhasspy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92 Mic92 requested a review from mweinelt Aug 1, 2020

stdenv.mkDerivation rec {
pname = "phonetisaurus";
version = "2020-07-31";

This comment has been minimized.

Copy link
@Mic92

Mic92 Aug 1, 2020

Author Contributor

Needs to be unstable to be compatible with openfst.

This comment has been minimized.

Copy link
@Mic92

Mic92 Aug 1, 2020

Author Contributor

I asked for a release here: AdolfVonKleist/Phonetisaurus#61

@Mic92
Copy link
Contributor Author

Mic92 commented Aug 1, 2020

This is a preparation for rhasspy.

openfst = callPackage ../development/libraries/openfst {};

opengrm-ngram = callPackage ../development/libraries/opengrm-ngram {};

phonetisaurus = callPackage ../development/libraries/phonetisaurus {};
Comment on lines 27139 to +27143

This comment has been minimized.

Copy link
@Mic92

Mic92 Aug 1, 2020

Author Contributor

All three are related so I keep them together.

@mweinelt
Copy link
Member

mweinelt commented Aug 1, 2020

Result of nixpkgs-review pr 94465 1

2 packages built:
- opengrm-ngram
- phonetisaurus
Copy link
Member

mweinelt left a comment

Some minor nits.

Mic92 and others added 2 commits Aug 1, 2020
Co-authored-by: Martin Weinelt <mweinelt@users.noreply.github.com>
@Mic92 Mic92 force-pushed the Mic92:rhasspy-upstream branch from 499ba48 to d29b7d9 Aug 1, 2020
@Mic92
Copy link
Contributor Author

Mic92 commented Aug 1, 2020

rebased!

@mweinelt mweinelt merged commit ab5af37 into NixOS:master Aug 1, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d29b7d9"; rev="d29b7d91d925c17d10eb521a3f6a1ccb175e563e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d29b7d9"; rev="d29b7d91d925c17d10eb521a3f6a1ccb175e563e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d29b7d9"; rev="d29b7d91d925c17d10eb521a3f6a1ccb175e563e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d29b7d9"; rev="d29b7d91d925c17d10eb521a3f6a1ccb175e563e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d29b7d9"; rev="d29b7d91d925c17d10eb521a3f6a1ccb175e563e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d29b7d9"; rev="d29b7d91d925c17d10eb521a3f6a1ccb175e563e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d29b7d9"; rev="d29b7d91d925c17d10eb521a3f6a1ccb175e563e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
opengrm-ngram, opengrm-ngram.passthru.tests, phonetisaurus, phonetisaurus.passthru.tests on aarch64-linux Success
Details
opengrm-ngram, opengrm-ngram.passthru.tests, phonetisaurus, phonetisaurus.passthru.tests on x86_64-darwin Success
Details
opengrm-ngram, opengrm-ngram.passthru.tests, phonetisaurus, phonetisaurus.passthru.tests on x86_64-linux Success
Details
@mweinelt
Copy link
Member

mweinelt commented Aug 1, 2020

merged!

@Mic92 Mic92 deleted the Mic92:rhasspy-upstream branch Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.