Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu-lazer: 2020.725.0 -> 2020.801.0 #94468

Closed
wants to merge 1 commit into from
Closed

Conversation

@oxalica
Copy link
Contributor

oxalica commented Aug 1, 2020

Motivation for this change

Bump version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dasj19
dasj19 approved these changes Aug 2, 2020
Copy link
Contributor

dasj19 left a comment

Built with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94468". Builds and runs just fine.

You can thick the 3rd checkbox in the description-

@dasj19
Copy link
Contributor

dasj19 commented Aug 2, 2020

This PR is aiming for the same thing as : #94542

@ryantm
Copy link
Member

ryantm commented Aug 2, 2020

Looks like I need to work on my PR duplicate checking for updateScript updates!

@oxalica
Copy link
Contributor Author

oxalica commented Aug 2, 2020

@ryantm Thanks for the bot update. Does all packages from GitHub with updateScript handled by the bot?

@ryantm
Copy link
Member

ryantm commented Aug 2, 2020

@oxalica I just started doing updateScript updates, so I can't comment on how well it works yet.

@oxalica
Copy link
Contributor Author

oxalica commented Aug 6, 2020

Merged in #94542

@oxalica oxalica closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.