Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navi: init at 2.7.1 #94469

Merged
merged 2 commits into from Aug 4, 2020
Merged

navi: init at 2.7.1 #94469

merged 2 commits into from Aug 4, 2020

Conversation

@cust0dian
Copy link
Contributor

cust0dian commented Aug 1, 2020

Motivation for this change

navi allows you to browse through cheatsheets (that you may write yourself or download from maintainers) and execute commands. Argument suggestions are prompted to you.

https://github.com/denisidoro/navi

Closes #82476 (previous attempt at packaging it) since it seems to have stagnated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
cust0dian added 2 commits Aug 1, 2020

nativeBuildInputs = [ makeWrapper ];

postInstall = ''

This comment has been minimized.

Copy link
@danieldk

danieldk Aug 4, 2020

Member

Upstream also provides shell completion files:

https://github.com/denisidoro/navi/tree/master/shell

You install install them using installShellCompletion after putting installShellFiles in nativeBuildInputs.

This comment has been minimized.

Copy link
@cust0dian

cust0dian Aug 4, 2020

Author Contributor

They are not really completions, they are adding key binding for navi widget, and upstream recommends opting into it via invoking subcommand in your rc file — would we want to implicitly set it up for users?

This comment has been minimized.

Copy link
@danieldk

danieldk Aug 4, 2020

Member

Ah, sorry for the noise. No, I don't think we should set them up implicitly.

This comment has been minimized.

Copy link
@cust0dian

cust0dian Aug 4, 2020

Author Contributor

No worries, thank you for review!

Copy link
Member

danieldk left a comment

LGTM

Result of nixpkgs-review pr 94469 1

1 package built:
  • navi

The program seems to work as expected. Thanks a lot for contributing this!

@danieldk danieldk merged commit b56eb10 into NixOS:master Aug 4, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ddf5fc"; rev="2ddf5fc2e4cdb3c8102570808a168585a02a1cf5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ddf5fc"; rev="2ddf5fc2e4cdb3c8102570808a168585a02a1cf5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ddf5fc"; rev="2ddf5fc2e4cdb3c8102570808a168585a02a1cf5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ddf5fc"; rev="2ddf5fc2e4cdb3c8102570808a168585a02a1cf5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ddf5fc"; rev="2ddf5fc2e4cdb3c8102570808a168585a02a1cf5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ddf5fc"; rev="2ddf5fc2e4cdb3c8102570808a168585a02a1cf5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ddf5fc"; rev="2ddf5fc2e4cdb3c8102570808a168585a02a1cf5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
navi, navi.passthru.tests on aarch64-linux Success
Details
navi, navi.passthru.tests on x86_64-linux Success
Details
@cust0dian cust0dian deleted the cust0dian:navi-2.7.1 branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.