Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homeassistant: 0.113.0 -> 0.113.3 #94475

Merged
merged 2 commits into from Aug 3, 2020
Merged

homeassistant: 0.113.0 -> 0.113.3 #94475

merged 2 commits into from Aug 3, 2020

Conversation

@mweinelt
Copy link
Member

mweinelt commented Aug 1, 2020

Motivation for this change

https://github.com/home-assistant/core/releases/tag/0.113.1
https://github.com/home-assistant/core/releases/tag/0.113.2
https://github.com/home-assistant/core/releases/tag/0.113.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg test home-assistant

@Mic92
Copy link
Contributor

Mic92 commented Aug 2, 2020

@GrahamcOfBorg build homeassistant

@Mic92
Copy link
Contributor

Mic92 commented Aug 2, 2020

I am currently seeing this test error:

@Mic92
Copy link
Contributor

Mic92 commented Aug 2, 2020

@Mic92
Copy link
Contributor

Mic92 commented Aug 2, 2020

@GrahamcOfBorg build home-assistant

@Mic92
Copy link
Contributor

Mic92 commented Aug 2, 2020

I also tried to rebase this on upstream/master but it seems to be still a problem. Not sure why this is not triggered here.

@Mic92
Copy link
Contributor

Mic92 commented Aug 2, 2020

Mhm. Now it seems to work for me as well? Maybe its a flacky test?

@mweinelt
Copy link
Member Author

mweinelt commented Aug 2, 2020

Indeed is flaky, I didn't run into this issue when I first ran the test, now I do.

The test was introduced in 0.113.2: home-assistant/core#38311

@mweinelt
Copy link
Member Author

mweinelt commented Aug 2, 2020

The timeout given here is probably a bit too tight:

diff --git a/tests/test_core.py b/tests/test_core.py
index 12ed00fde2..877eac226a 100644
--- a/tests/test_core.py
+++ b/tests/test_core.py
@@ -1447,7 +1447,7 @@ async def test_chained_logging_hits_log_timeout(hass, caplog):
             return
         hass.async_create_task(_task_chain_1())
 
-    with patch.object(ha, "BLOCK_LOG_TIMEOUT", 0.0001):
+    with patch.object(ha, "BLOCK_LOG_TIMEOUT", 0.001):
         hass.async_create_task(_task_chain_1())
         await hass.async_block_till_done()

I'll raise this issue upstream.

@Mic92
Copy link
Contributor

Mic92 commented Aug 2, 2020

Ok. We can apply the pull request patch.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 2, 2020

Spoke too quick, that doesn't fix it for me.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 2, 2020

Upstream issue home-assistant/core#38476

@mweinelt
Copy link
Member Author

mweinelt commented Aug 3, 2020

Ok. We can apply the pull request patch.

Done.

@mweinelt mweinelt merged commit df51033 into NixOS:master Aug 3, 2020
18 checks passed
18 checks passed
tests tests
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87d4e12"; rev="87d4e1230b458b3a43a18003fa22ad7f98a831df"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87d4e12"; rev="87d4e1230b458b3a43a18003fa22ad7f98a831df"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87d4e12"; rev="87d4e1230b458b3a43a18003fa22ad7f98a831df"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87d4e12"; rev="87d4e1230b458b3a43a18003fa22ad7f98a831df"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87d4e12"; rev="87d4e1230b458b3a43a18003fa22ad7f98a831df"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87d4e12"; rev="87d4e1230b458b3a43a18003fa22ad7f98a831df"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87d4e12"; rev="87d4e1230b458b3a43a18003fa22ad7f98a831df"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
home-assistant, home-assistant.passthru.tests on aarch64-linux Success
Details
home-assistant, home-assistant.passthru.tests on x86_64-linux Success
Details
@mweinelt mweinelt deleted the mweinelt:hass branch Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.