Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyHS100: init at 0.3.5.1 #94483

Merged
merged 3 commits into from Aug 3, 2020
Merged

Conversation

@mweinelt
Copy link
Member

mweinelt commented Aug 1, 2020

Motivation for this change

Ability to control TP-Link smart devices from within home-assistant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt mweinelt force-pushed the mweinelt:pyhs100 branch from b9ad43b to 94c0c2b Aug 2, 2020
@@ -2570,6 +2572,8 @@ in {

pyhcl = callPackage ../development/python-modules/pyhcl { };

pyHS100 = callPackage ../development/python-modules/pyHS100 { };

This comment has been minimized.

@FRidh

FRidh Aug 2, 2020 Member

normalized name, so pyhs100

This comment has been minimized.

@mweinelt

mweinelt Aug 2, 2020 Author Member

Done.

@mweinelt mweinelt force-pushed the mweinelt:pyhs100 branch from 94c0c2b to 9bf5e1b Aug 2, 2020
@mweinelt mweinelt force-pushed the mweinelt:pyhs100 branch from 9bf5e1b to b5b3567 Aug 2, 2020
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 94483 1

5 packages built: - python27Packages.click-datetime - python37Packages.click-datetime - python37Packages.pyhs100 - python38Packages.click-datetime - python38Packages.pyhs100

@jonringer jonringer merged commit fd2c4f0 into NixOS:master Aug 3, 2020
18 checks passed
18 checks passed
tests tests
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b3567"; rev="b5b3567db66f421923f33c77b3afa0bc3d8c2fbb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b3567"; rev="b5b3567db66f421923f33c77b3afa0bc3d8c2fbb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b3567"; rev="b5b3567db66f421923f33c77b3afa0bc3d8c2fbb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b3567"; rev="b5b3567db66f421923f33c77b3afa0bc3d8c2fbb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b3567"; rev="b5b3567db66f421923f33c77b3afa0bc3d8c2fbb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b3567"; rev="b5b3567db66f421923f33c77b3afa0bc3d8c2fbb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b5b3567"; rev="b5b3567db66f421923f33c77b3afa0bc3d8c2fbb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
home-assistant, home-assistant.passthru.tests on aarch64-linux Success
Details
home-assistant, home-assistant.passthru.tests on x86_64-linux Success
Details
@mweinelt mweinelt deleted the mweinelt:pyhs100 branch Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.