Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/postfix: migrate test to use tlsTrustedAuthorities #94484

Open
wants to merge 2 commits into
base: master
from

Conversation

@mweinelt
Copy link
Member

mweinelt commented Aug 1, 2020

Motivation for this change

This fixes the tests to work after 632104e.

Discovered in #94457 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes: 632104e ("postfix: deprecated `sslCACert` in favour of
`tlsTrustedAuthorities`")
@mweinelt
Copy link
Member Author

mweinelt commented Aug 1, 2020

@mweinelt
Copy link
Member Author

mweinelt commented Aug 2, 2020

This also adds passthru.tests.

@mweinelt mweinelt mentioned this pull request Aug 2, 2020
5 of 10 tasks complete
@mweinelt mweinelt force-pushed the mweinelt:postfix branch from 4781398 to 1da7f9f Aug 2, 2020
@mweinelt mweinelt requested review from rickynils and globin Aug 14, 2020
@mweinelt
Copy link
Member Author

mweinelt commented Sep 3, 2020

Hey @asbachb, can you please check this?

@asbachb
Copy link
Contributor

asbachb commented Sep 11, 2020

@mweinelt tbh I don't feel competent enough with nixos testsing to approve the changes.

/cc @peti @nlewo can you help out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.