Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flip: init at v1.40-pre #94508

Closed
wants to merge 1 commit into from
Closed

flip: init at v1.40-pre #94508

wants to merge 1 commit into from

Conversation

@djanatyn
Copy link
Contributor

@djanatyn djanatyn commented Aug 2, 2020

Motivation for this change

Patch tool for IPS and BPS files on NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@IvarWithoutBones
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones commented Aug 3, 2020

There seems to be another PR open for this package already.

@djanatyn
Copy link
Contributor Author

@djanatyn djanatyn commented Aug 4, 2020

Thank you, I forgot to check! Closing, looks like that PR is more appropriate.

@djanatyn djanatyn closed this Aug 4, 2020
@xfix xfix mentioned this pull request Aug 23, 2020
6 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.