Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomacs: 3.15.1616 -> 3.16.224 #94536

Merged
merged 1 commit into from Aug 3, 2020
Merged

nomacs: 3.15.1616 -> 3.16.224 #94536

merged 1 commit into from Aug 3, 2020

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Aug 2, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/nomacs/nomacs/releases.

meta.description for nomacs is: "Qt-based image viewer"

meta.homepage for nomacs is: "https://nomacs.org"

meta.changelog for nomacs is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
nomacs
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/90yaay3cnr9znfvp5qn32s6xm7c7yfp8-nomacs-3.16.224 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A nomacs https://github.com/r-ryantm/nixpkgs/archive/7d9695b7f14b42c67c2c52a295a9a9ed967945c6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/90yaay3cnr9znfvp5qn32s6xm7c7yfp8-nomacs-3.16.224
ls -la /nix/store/90yaay3cnr9znfvp5qn32s6xm7c7yfp8-nomacs-3.16.224/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
  • nomacs

Maintainer pings

cc @Mindavi for testing.

@Mindavi
Copy link
Contributor

@Mindavi Mindavi commented Aug 3, 2020

Build on my machine, basic functionality (viewing jpgs, some simple editing) seems to work. LGTM. Only tested on x86 NixOS, but I don't expect much regressions if the build succeeds.

Looking through the diffs does not show any obvious compatibility issues.

@ryantm ryantm merged commit 4eec1d6 into NixOS:master Aug 3, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d9695b"; rev="7d9695b7f14b42c67c2c52a295a9a9ed967945c6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d9695b"; rev="7d9695b7f14b42c67c2c52a295a9a9ed967945c6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d9695b"; rev="7d9695b7f14b42c67c2c52a295a9a9ed967945c6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d9695b"; rev="7d9695b7f14b42c67c2c52a295a9a9ed967945c6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d9695b"; rev="7d9695b7f14b42c67c2c52a295a9a9ed967945c6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d9695b"; rev="7d9695b7f14b42c67c2c52a295a9a9ed967945c6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d9695b"; rev="7d9695b7f14b42c67c2c52a295a9a9ed967945c6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nomacs, nomacs.passthru.tests on aarch64-linux Success
Details
nomacs, nomacs.passthru.tests on x86_64-darwin Success
Details
nomacs, nomacs.passthru.tests on x86_64-linux Success
Details
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/nomacs branch Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.