Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
nixos/dokuwiki: fix https redirect #94551
Even if the webserver had https disabled, the user would still get redirected to an https url when attemting to login.
Motivation for this change
Fixes broken login behavior when https is disabled.
aanderse left a comment •
What do you do for dns? For our internal sites I use dns challenge with let's encrypt to provision ssl certificates and it's dead simple. I would highly recommend this over the alternative (though I still approve this PR
Also I'm a huge fan of your avatar
1000101 left a comment •
I basically agree with what @aanderse said. Just for the record, I was thinking about dropping the current SSL configuration altogether as it's imposing a given configuration on the user rather than leaving it up to him/her: #83769 (comment)
@dadada I think we should also document this service in the 20.09 release notes as the service changed from single-site to multi-site and this may break existing configuration.