Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shipyard: init at 0.1.0 #94561

Open
wants to merge 1 commit into
base: master
from
Open

shipyard: init at 0.1.0 #94561

wants to merge 1 commit into from

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Aug 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
pkgs/tools/virtualization/shipyard/default.nix Outdated Show resolved Hide resolved
@cpcloud cpcloud force-pushed the cpcloud:shipyard branch from 5f1cd7c to cd09090 Aug 8, 2020
@cpcloud
Copy link
Contributor Author

@cpcloud cpcloud commented Aug 8, 2020

Looks like a new release happened since I opened this PR, going to give this one a new title and rebase+squash.

@cpcloud cpcloud changed the title shipyard: init at 0.0.37 shipyard: init at 0.1.0 Aug 8, 2020
@cpcloud cpcloud force-pushed the cpcloud:shipyard branch from cd09090 to 0bf7f5b Aug 8, 2020
@cpcloud cpcloud requested a review from doronbehar Aug 8, 2020
Copy link
Contributor

@doronbehar doronbehar left a comment

Passes nixpkgs-review build and --help test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.