Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.brother: init at 0.1.14 #94568

Merged
merged 4 commits into from Aug 4, 2020
Merged

python3Packages.brother: init at 0.1.14 #94568

merged 4 commits into from Aug 4, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Aug 2, 2020

Motivation for this change

Enable the brother integration in home-assistant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@lsix lsix left a comment

nix-review gives me that:

[8 built (2 failed), 105 copied (197.3 MiB), 43.9 MiB DL]
error: build of '/nix/store/wark1gyjszmbycf8xw9k1sn9cm5s2cbz-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/94568
2 packages failed to build:
python27Packages.pytest-tornasync python37Packages.brother

5 packages built:
python37Packages.pytest-tornasync python37Packages.pytest-trio python38Packages.brother python38Packages.pytest-tornasync python38Packages.pytest-trio

I did not look into it, but it should be looked into or some packages should probably be disabled for some python versions (if this is the problem).

@mweinelt mweinelt force-pushed the mweinelt:brother branch from 8f34624 to aa858bc Aug 3, 2020
@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Aug 3, 2020

I set pytest-toransync to >=3.5.

The python3.7 version of brother is failing in asynctest, which has had its test disabled for 3.8, which is apparently also necessary for 3.7, see 25b91c2.

@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Aug 4, 2020

Disabled the asynctest tests on python 3.7 in #94655. Thinks are looking good now afaict.

mweinelt added 4 commits Aug 2, 2020
@mweinelt mweinelt force-pushed the mweinelt:brother branch from a6a09e4 to a81ab51 Aug 4, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 94568 1

1 package failed to build:
- python27Packages.pytest-tornasync
6 packages built:
- python37Packages.brother
- python37Packages.pytest-tornasync
- python37Packages.pytest-trio
- python38Packages.brother
- python38Packages.pytest-tornasync
- python38Packages.pytest-trio

@jonringer jonringer merged commit 0480361 into NixOS:master Aug 4, 2020
16 of 18 checks passed
16 of 18 checks passed
tests tests
Details
tests
Details
home-assistant, home-assistant.passthru.tests on aarch64-linux
Details
home-assistant, home-assistant.passthru.tests on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a81ab51"; rev="a81ab514ac859ef48002dbb12e0d85f85c1080f1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a81ab51"; rev="a81ab514ac859ef48002dbb12e0d85f85c1080f1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a81ab51"; rev="a81ab514ac859ef48002dbb12e0d85f85c1080f1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a81ab51"; rev="a81ab514ac859ef48002dbb12e0d85f85c1080f1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a81ab51"; rev="a81ab514ac859ef48002dbb12e0d85f85c1080f1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a81ab51"; rev="a81ab514ac859ef48002dbb12e0d85f85c1080f1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a81ab51"; rev="a81ab514ac859ef48002dbb12e0d85f85c1080f1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mweinelt mweinelt deleted the mweinelt:brother branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.