Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/editorconfig.yml: separate fetch and check steps #94575

Merged
merged 1 commit into from Aug 3, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 2, 2020

Separate steps should be easier to read.

Also rename the tool to match what we have packaged.

/nix/store/bnlc49ibgdy904mlpv67h3x6jnf17xz7-editorconfig-checker-2.1.0/bin/editorconfig-checker
@zowoq zowoq requested a review from Mic92 as a code owner Aug 2, 2020
@zowoq zowoq force-pushed the zowoq:ecc-actions branch from a763270 to 3039699 Aug 2, 2020
Copy link
Member

@mweinelt mweinelt left a comment

LGTM. Needs rebasing.

@zowoq zowoq force-pushed the zowoq:ecc-actions branch from 3039699 to 2094108 Aug 3, 2020
@zowoq zowoq force-pushed the zowoq:ecc-actions branch from 2094108 to c1fce8f Aug 3, 2020
mv ./bin/ec-$OS-$ARCH ./bin/editorconfig-checker
- name: Checking EditorConfig
run: |
./bin/editorconfig-checker -disable-indentation \

This comment has been minimized.

@mweinelt

mweinelt Aug 3, 2020
Member

That line break does not feel necessary, even with the line below you are below 80 characters. And IMO it does not improve readability.

This comment has been minimized.

@zowoq

zowoq Aug 3, 2020
Author Contributor

It's for when multiple files are edited so that they are all after the break rather than being cut off.

This comment has been minimized.

@mweinelt

mweinelt Aug 3, 2020
Member

Okay, works for me.

@mweinelt mweinelt merged commit f284867 into NixOS:master Aug 3, 2020
15 checks passed
15 checks passed
tests tests
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1fce8f"; rev="c1fce8f814830a5ce1f381158d315323fc01700b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1fce8f"; rev="c1fce8f814830a5ce1f381158d315323fc01700b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1fce8f"; rev="c1fce8f814830a5ce1f381158d315323fc01700b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1fce8f"; rev="c1fce8f814830a5ce1f381158d315323fc01700b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1fce8f"; rev="c1fce8f814830a5ce1f381158d315323fc01700b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1fce8f"; rev="c1fce8f814830a5ce1f381158d315323fc01700b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c1fce8f"; rev="c1fce8f814830a5ce1f381158d315323fc01700b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:ecc-actions branch Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.