Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nss on macOS #94587

Merged
merged 3 commits into from Aug 6, 2020
Merged

Fix nss on macOS #94587

merged 3 commits into from Aug 6, 2020

Conversation

@matthewbauer
Copy link
Member

matthewbauer commented Aug 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@vcunat
Copy link
Member

vcunat commented Aug 3, 2020

Oh, I thought we fixed darwin in #93534

@matthewbauer
Copy link
Member Author

matthewbauer commented Aug 3, 2020

Oh, I thought we fixed darwin in #93534

That made it build - but the install name is relative to the executable without d0468f8.

@vcunat
Copy link
Member

vcunat commented Aug 3, 2020

Hmm, tough for people without a macOS to fix, if the builds themselves don't test such things.

@marsam
marsam approved these changes Aug 5, 2020
@vcunat vcunat merged commit ce174c7 into NixOS:master Aug 6, 2020
19 checks passed
19 checks passed
tests tests
Details
tests
Details
lzfse, lzfse.passthru.tests, nss, nss.passthru.tests on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d0468f8"; rev="d0468f86e8e0fa59f6ee8fa493d68abc61facd98"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d0468f8"; rev="d0468f86e8e0fa59f6ee8fa493d68abc61facd98"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d0468f8"; rev="d0468f86e8e0fa59f6ee8fa493d68abc61facd98"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d0468f8"; rev="d0468f86e8e0fa59f6ee8fa493d68abc61facd98"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d0468f8"; rev="d0468f86e8e0fa59f6ee8fa493d68abc61facd98"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d0468f8"; rev="d0468f86e8e0fa59f6ee8fa493d68abc61facd98"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d0468f8"; rev="d0468f86e8e0fa59f6ee8fa493d68abc61facd98"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
lzfse, lzfse.passthru.tests, nss, nss.passthru.tests on aarch64-linux Success
Details
lzfse, lzfse.passthru.tests, nss, nss.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.