Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] Firefox 79 #94746

Merged
Merged

Conversation

@ajs124
Copy link
Member

ajs124 commented Aug 5, 2020

cc @vcunat @andir @taku0

Thunderbird is still compiling,seems to work fine.
Although we could actually just not compile it with the newer rust.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124 ajs124 requested review from LnL7 and Mic92 as code owners Aug 5, 2020
@andir andir self-assigned this Aug 5, 2020
@ofborg ofborg bot added the 6.topic: rust label Aug 5, 2020
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested review from andir and edolstra Aug 5, 2020
@ajs124 ajs124 force-pushed the helsinki-systems:backport/20.03/firefox-79 branch 2 times, most recently from 012b5dc to 0b4ff85 Aug 5, 2020
alyssais and others added 3 commits Jul 16, 2020
Thunderbird and Firefox don't build with 1.41 (or 1.45 for that matter)

based on 1f9cd4c
firefox 79 needs this

based on cebca41
@ajs124 ajs124 force-pushed the helsinki-systems:backport/20.03/firefox-79 branch from 0b4ff85 to 0c700a5 Aug 5, 2020
@andir
Copy link
Member

andir commented Aug 5, 2020

I am getting a segfault when trying to execute this on nixos-unstable. Just before the crash it spits out an error about fontconfig. I guess that might be a fontconfig and/or glibc upgrade that broke compat with the running system?

That being said test are running just fine.

@@ -53,7 +55,7 @@

# dependencies requires for stable backports

, rust-cbindgen_0_14_1

This comment has been minimized.

@andir

andir Aug 5, 2020 Member

Last nitpick: SInce we are touching these lines how about we merge this block with the one above at line 19-22? Would be more consistent and we wouldn't have two "blocks" for backports :)

@andir
andir approved these changes Aug 5, 2020
Copy link
Member

andir left a comment

Besides that one nitpick this looks fine. I assume the segfault I got (outside of the nixos test) was from some incompat between unstable (my current system channel) and 20.03.

(cherry picked from commit 6a4e0ee)
@ajs124 ajs124 force-pushed the helsinki-systems:backport/20.03/firefox-79 branch from 0c700a5 to 74ddece Aug 5, 2020
@ajs124
Copy link
Member Author

ajs124 commented Aug 5, 2020

Done.
It ran fine for me on 20.03. Would be cool if someone else could test it, though.

@ofborg ofborg bot requested a review from andir Aug 6, 2020
@flokli
Copy link
Contributor

flokli commented Aug 6, 2020

Successfully built this, and ran the firefox VM test.

@flokli flokli merged commit e23e054 into NixOS:release-20.03 Aug 6, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74ddece"; rev="74ddece7310bded051942631ac5b7ccdc6a00b45"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74ddece"; rev="74ddece7310bded051942631ac5b7ccdc6a00b45"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74ddece"; rev="74ddece7310bded051942631ac5b7ccdc6a00b45"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74ddece"; rev="74ddece7310bded051942631ac5b7ccdc6a00b45"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74ddece"; rev="74ddece7310bded051942631ac5b7ccdc6a00b45"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74ddece"; rev="74ddece7310bded051942631ac5b7ccdc6a00b45"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74ddece"; rev="74ddece7310bded051942631ac5b7ccdc6a00b45"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nspr_latest, nspr_latest.passthru.tests on aarch64-linux Success
Details
nspr_latest, nspr_latest.passthru.tests on x86_64-linux Success
Details
@ajs124 ajs124 deleted the helsinki-systems:backport/20.03/firefox-79 branch Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.