Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk8: 1.8.0_242 -> 1.8.0_265 #94789

Merged
merged 1 commit into from Aug 7, 2020
Merged

Conversation

@jerith666
Copy link
Contributor

jerith666 commented Aug 6, 2020

Note that a -ga tag hasn't appeared in the aarch64 repo, so I had to use b01. :-/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@NeQuissimus
Copy link
Member

NeQuissimus commented Aug 6, 2020

Is this the same as #94573 ?

@jerith666
Copy link
Contributor Author

jerith666 commented Aug 6, 2020

Yep. cc @asbachb .

@asbachb
Copy link
Contributor

asbachb commented Aug 6, 2020

It seems that you got the aarch64 hashes right. So let's usw this one instead of mine.

@NeQuissimus NeQuissimus merged commit b71dc9d into NixOS:master Aug 7, 2020
18 checks passed
18 checks passed
tests tests
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0afe6a2"; rev="0afe6a282a52054fbedec9d262b32ddb066271e2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0afe6a2"; rev="0afe6a282a52054fbedec9d262b32ddb066271e2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0afe6a2"; rev="0afe6a282a52054fbedec9d262b32ddb066271e2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0afe6a2"; rev="0afe6a282a52054fbedec9d262b32ddb066271e2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0afe6a2"; rev="0afe6a282a52054fbedec9d262b32ddb066271e2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0afe6a2"; rev="0afe6a282a52054fbedec9d262b32ddb066271e2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0afe6a2"; rev="0afe6a282a52054fbedec9d262b32ddb066271e2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
openjdk8, openjdk8.passthru.tests on aarch64-linux Success
Details
openjdk8, openjdk8.passthru.tests on x86_64-linux Success
Details
@asbachb
Copy link
Contributor

asbachb commented Aug 7, 2020

I guess we should backport this to 20.03 as well.

@NeQuissimus
Copy link
Member

NeQuissimus commented Aug 7, 2020

@asbachb Would you be able to do that for me? :) Thx!

@asbachb
Copy link
Contributor

asbachb commented Aug 7, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.