Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinygo: include files from gen-device #94794

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@yvesf
Copy link
Contributor

yvesf commented Aug 6, 2020

Motivation for this change

fix #94793

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@yvesf
Copy link
Contributor Author

yvesf commented Aug 6, 2020

Unfortunately, building a binary for an nrf-based board is still failing:

$ tinygo build -target=microbit -o test
error: failed to build /nix/store/dlas998iig5xgmllr25kl5y97kfa35p5-tinygo-0.13.1/share/tinygo/lib/compiler-rt/lib/builtins/absvdi2.c: none of these commands were found in your $PATH: clang-10

Tinygo tries to find find clang under the name clang-10. If I patch this to also try just clang it fails with:

$ tinygo build -target=microbit -o test
clang-10: error: argument unused during compilation: '-nostdlibinc' [-Werror,-Wunused-command-line-argument]
clang-10: error: argument unused during compilation: '--gcc-toolchain=/nix/store/b3zsk4ihlpiimv3vff86bb5bxghgdzb9-gcc-9.2.0' [-Werror,-Wunused-command-line-argument]
error: failed to build /nix/store/vd8hhfnr22kmv0b8szlbpd4yj4sj3q9g-tinygo-0.13.1/share/tinygo/lib/compiler-rt/lib/builtins/absvdi2.c: exit status 1```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.