Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold: 1.12.1 → 1.13.1 #94802

Merged
merged 1 commit into from Aug 7, 2020
Merged

skaffold: 1.12.1 → 1.13.1 #94802

merged 1 commit into from Aug 7, 2020

Conversation

@blaggacao
Copy link
Contributor

blaggacao commented Aug 6, 2020

See nix-review output below

Follow up on: #93680

Before this PR, k3d support is currently broken.

  • manually tested executable
@blaggacao
Copy link
Contributor Author

blaggacao commented Aug 6, 2020

Result of nixpkgs-review pr 94802 1

1 package built:
- skaffold
@blaggacao blaggacao changed the title update: skaffold (1.12.1 → 1.13.1) skaffold: 1.12.1 → 1.13.1 Aug 6, 2020
@blaggacao blaggacao force-pushed the xoe-labs:da-update-skaffold branch from 481bf1c to 77c4dae Aug 6, 2020
@nixos-discourse
Copy link

nixos-discourse commented Aug 6, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/249

@blaggacao
Copy link
Contributor Author

blaggacao commented Aug 6, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 6, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested a review from vdemeester Aug 6, 2020
@marsam marsam merged commit dc2aa26 into NixOS:master Aug 7, 2020
18 checks passed
18 checks passed
tests tests
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77c4dae"; rev="77c4dae8bcf4ea667f3a38f57abb28af958909a6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77c4dae"; rev="77c4dae8bcf4ea667f3a38f57abb28af958909a6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77c4dae"; rev="77c4dae8bcf4ea667f3a38f57abb28af958909a6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77c4dae"; rev="77c4dae8bcf4ea667f3a38f57abb28af958909a6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77c4dae"; rev="77c4dae8bcf4ea667f3a38f57abb28af958909a6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77c4dae"; rev="77c4dae8bcf4ea667f3a38f57abb28af958909a6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="77c4dae"; rev="77c4dae8bcf4ea667f3a38f57abb28af958909a6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
skaffold, skaffold.passthru.tests on aarch64-linux Success
Details
skaffold, skaffold.passthru.tests on x86_64-linux Success
Details
@blaggacao blaggacao deleted the xoe-labs:da-update-skaffold branch Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.