Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/postgresql: fix setup script #94805

Merged
merged 1 commit into from Aug 6, 2020
Merged

Conversation

@bachp
Copy link
Member

bachp commented Aug 6, 2020

Motivation for this change

After #94454 postgresql didn't start up on my machine anymore.

After some analysis I think the missing () caused parts of the setup script to be added to the
ExecStartPost line instead of inside the script.

This caused postgresql start to fail under certain conditions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The missing () caused parts of the escripts to be added to the
ExecStartPost line instead of inside the script.

This caused postgresql start to fail under certain conditions.
Copy link
Contributor

aanderse left a comment

@bachp sorry for the hassle. I'm a bit confused how the test successfully completed with this mistake... 🤔 Thanks for catching and fixing 👍

@aanderse
Copy link
Contributor

aanderse commented Aug 6, 2020

@GrahamcOfBorg test postgresql postgresql-wal-receiver

@flokli flokli merged commit d7f0530 into NixOS:master Aug 6, 2020
17 checks passed
17 checks passed
tests tests
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cee4e14"; rev="cee4e14bdf7302e48d313264c0c34a418320bba5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cee4e14"; rev="cee4e14bdf7302e48d313264c0c34a418320bba5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cee4e14"; rev="cee4e14bdf7302e48d313264c0c34a418320bba5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cee4e14"; rev="cee4e14bdf7302e48d313264c0c34a418320bba5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cee4e14"; rev="cee4e14bdf7302e48d313264c0c34a418320bba5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cee4e14"; rev="cee4e14bdf7302e48d313264c0c34a418320bba5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cee4e14"; rev="cee4e14bdf7302e48d313264c0c34a418320bba5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.postgresql, tests.postgresql-wal-receiver on aarch64-linux Success
Details
tests.postgresql, tests.postgresql-wal-receiver on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.