Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport discord #94817

Merged
merged 3 commits into from Aug 6, 2020
Merged

Backport discord #94817

merged 3 commits into from Aug 6, 2020

Conversation

@jonringer
Copy link
Contributor

jonringer commented Aug 6, 2020

Motivation for this change

backport #94811 #94814

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/94817
3 packages built:
discord discord-canary discord-ptb
ldesgoui and others added 3 commits Aug 6, 2020
(cherry picked from commit ded6c3d)
(cherry picked from commit 76ee4f6)
(cherry picked from commit 9fbbe30)
@jonringer
Copy link
Contributor Author

jonringer commented Aug 6, 2020

I apologize for spam, wrong base branch

@jonringer jonringer merged commit 825c68c into NixOS:release-20.03 Aug 6, 2020
@jonringer jonringer deleted the jonringer:backport-discord branch Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.