Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chatty and feedbackd #94820

Open
wants to merge 3 commits into
base: master
from
Open

Add Chatty and feedbackd #94820

wants to merge 3 commits into from

Conversation

@masipcat
Copy link

masipcat commented Aug 6, 2020

Motivation for this change

Use this amazing application from Librem

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@masipcat masipcat force-pushed the masipcat:chatty-feedbackd branch from ce6bb38 to 7338bfc Aug 6, 2020
@masipcat
Copy link
Author

masipcat commented Aug 6, 2020

Some screenshots:

image

image

@masipcat
Copy link
Author

masipcat commented Aug 6, 2020

Right now Chatty is built without any libpurple plugin and only works as a xmpp client. I'm not sure if we want to do something similar to pidgin-with-plugins. What do you think?

@masipcat
Copy link
Author

masipcat commented Aug 7, 2020

When this PR is merged the package calls can be update to latest version cc/ @craigem @lheckemann

@masipcat
Copy link
Author

masipcat commented Aug 12, 2020

Do you want to review this PR @jtojnar @flokli ? :)

@masipcat masipcat force-pushed the masipcat:chatty-feedbackd branch 2 times, most recently from 5d9f980 to bde01ec Aug 15, 2020
@masipcat masipcat force-pushed the masipcat:chatty-feedbackd branch from bde01ec to 7c71800 Aug 15, 2020
@masipcat
Copy link
Author

masipcat commented Aug 15, 2020

@jtojnar Fixed :)

@jtojnar
Copy link
Contributor

jtojnar commented Aug 15, 2020

Yeah, agree that we will need chatty-with-plugins. Also likely a module for feedbackd.

@masipcat
Copy link
Author

masipcat commented Aug 15, 2020

Also likely a module for feedbackd.

What do you mean?

@jtojnar
Copy link
Contributor

jtojnar commented Aug 15, 2020

Since it is a daemon, it probably requires installing by setting systemd.packages, services.dbus.packages NixOS options or something like that. NixOS module could handle that.

@masipcat masipcat force-pushed the masipcat:chatty-feedbackd branch from 7c71800 to 0fda71a Aug 16, 2020
@masipcat
Copy link
Author

masipcat commented Aug 16, 2020

Added chatty-with-plugins. Successfully tested the following ones:

plugins = [ pkgs.pidgin-carbons pkgs.purple-lurch pkgs.telegram-purple ];
@jtojnar
Copy link
Contributor

jtojnar commented Aug 16, 2020

Looks like feedbackd does not seem to compile gsettings schemas. And also it does have a dbus service so it will not work without being installed globally (e.g. using a module).

@masipcat
Copy link
Author

masipcat commented Aug 16, 2020

Looks like feedbackd does not seem to compile gsettings schemas. And also it does have a dbus service so it will not work without being installed globally (e.g. using a module).

Working on a module + fixing gsettings!

@@ -70,6 +70,7 @@ mapAliases ({
casperjs = throw "casperjs has been removed, it was abandoned by upstream and broken.";
catfish = xfce.catfish; # added 2019-12-22
cgmanager = throw "cgmanager was deprecated by lxc and therefore removed from nixpkgs."; # added 2020-06-05
chatty-with-plugins = chatty; # added 2020-08-16

This comment has been minimized.

@jtojnar

jtojnar Aug 16, 2020 Contributor

Why add an legacy alias when this never existed?

This comment has been minimized.

@masipcat

masipcat Aug 23, 2020 Author

I'm sorry, we don't want an alias for the plugins or this file isn't the right place?

This comment has been minimized.

@jtojnar

jtojnar Aug 23, 2020 Contributor

I do not see a reason for adding a longer name for chatty-with-plugins when chatty allows setting plugins argument too. Also this file is oriented more towards lesser aliases and can be disabled using allowAliases = false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.