Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio: add .desktop file #94821

Merged
merged 1 commit into from Aug 6, 2020
Merged

factorio: add .desktop file #94821

merged 1 commit into from Aug 6, 2020

Conversation

@mweinelt
Copy link
Member

mweinelt commented Aug 6, 2020

Motivation for this change

Add a desktop file for factorio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt mweinelt requested review from Baughn, elitak and erictapen Aug 6, 2020
@mweinelt mweinelt force-pushed the mweinelt:factorio branch from 54f0e40 to 7987930 Aug 6, 2020
@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020

The icons are not yet showing for me in wofi.

@doronbehar
Copy link
Contributor

doronbehar commented Aug 6, 2020

Why draft?

@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020

Why draft?

#94821 (comment)

@mweinelt mweinelt force-pushed the mweinelt:factorio branch from 7987930 to 6dbeed2 Aug 6, 2020
Copy link

piegamesde left a comment

Works for me.

@mweinelt mweinelt marked this pull request as ready for review Aug 6, 2020
@mweinelt
Copy link
Member Author

mweinelt commented Aug 6, 2020

Works in rofi, doesn't work in wofi. Probably a wofi issue. 🤷

@mweinelt mweinelt merged commit 69b4099 into NixOS:master Aug 6, 2020
18 checks passed
18 checks passed
tests tests
Details
tests
Details
factorio, factorio.passthru.tests on aarch64-linux No attempt
Details
factorio, factorio.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dbeed2"; rev="6dbeed2d1d355b16145255a18321eacd32d93852"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dbeed2"; rev="6dbeed2d1d355b16145255a18321eacd32d93852"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dbeed2"; rev="6dbeed2d1d355b16145255a18321eacd32d93852"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dbeed2"; rev="6dbeed2d1d355b16145255a18321eacd32d93852"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dbeed2"; rev="6dbeed2d1d355b16145255a18321eacd32d93852"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dbeed2"; rev="6dbeed2d1d355b16145255a18321eacd32d93852"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dbeed2"; rev="6dbeed2d1d355b16145255a18321eacd32d93852"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mweinelt mweinelt deleted the mweinelt:factorio branch Aug 6, 2020
@priegger
Copy link
Contributor

priegger commented Aug 14, 2020

I think this broke the *-headless builds.

@mweinelt
Copy link
Member Author

mweinelt commented Aug 14, 2020

Ah, sorry we missed that. Guess we can move the steps into an alpha and demo specific installPhase.

@mweinelt mweinelt mentioned this pull request Aug 14, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.