Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helio-workstation: 2.2 -> 3.1 #94950

Merged
merged 1 commit into from Oct 8, 2020
Merged

helio-workstation: 2.2 -> 3.1 #94950

merged 1 commit into from Oct 8, 2020

Conversation

@suhr
Copy link
Contributor

@suhr suhr commented Aug 8, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@suhr suhr marked this pull request as ready for review Sep 20, 2020
@suhr suhr mentioned this pull request Sep 20, 2020
10 tasks
@suhr suhr assigned suhr and worldofpeace and unassigned suhr and worldofpeace Sep 20, 2020
@suhr suhr requested a review from worldofpeace Sep 20, 2020
@magnetophon
Copy link
Member

@magnetophon magnetophon commented Sep 20, 2020

It builds and runs, but everywhere I'd expect text, there is empty space.
Therefore I haven't been able to find the preferences menu, and have not been able to configure it to use jack.

Does it work for you, @suhr?

I did:

nixpkgs-review pr 94950
./results/helio-workstation/bin/Helio

@magnetophon
Copy link
Member

@magnetophon magnetophon commented Sep 20, 2020

After rm -r .config/Helio, I can see text, and configure it to use jack.
A jack port shows up, but I haven't been able to produce sound yet.
Probably PEBCAC though.

@suhr
Copy link
Contributor Author

@suhr suhr commented Sep 20, 2020

Make sure you run qjackctl before running Helio. Also, if you tried to use Helio without working jack, you will have to reset Helio configuration again.

@magnetophon
Copy link
Member

@magnetophon magnetophon commented Sep 20, 2020

Thanks. I had jack running already.

I have sound now, the missing step seemed to be to scan my plugins folder and assign an instrument to the track.
I had previously assigned the built-in piano, but that didn't work.

In any case the package seems to be working just fine, thanks!

@magnetophon magnetophon self-requested a review Sep 20, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 7, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/328

@Lassulus Lassulus merged commit 1cd6501 into NixOS:master Oct 8, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
helio-workstation, helio-workstation.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74d2819"; rev="74d28193d313a1058570083536e40b52f84c5ed0"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74d2819"; rev="74d28193d313a1058570083536e40b52f84c5ed0"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74d2819"; rev="74d28193d313a1058570083536e40b52f84c5ed0"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74d2819"; rev="74d28193d313a1058570083536e40b52f84c5ed0"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74d2819"; rev="74d28193d313a1058570083536e40b52f84c5ed0"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74d2819"; rev="74d28193d313a1058570083536e40b52f84c5ed0"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="74d2819"; rev="74d28193d313a1058570083536e40b52f84c5ed0"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
helio-workstation, helio-workstation.passthru.tests on x86_64-linux Success
Details
@suhr suhr deleted the helio branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants