Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undervolt: expose power limits as Nixopts #95011

Merged
merged 1 commit into from Oct 30, 2020
Merged

Conversation

@Atemu
Copy link
Member

@Atemu Atemu commented Aug 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
We no longer escape the flags because the power limit flags want two arguments
If we escaped them, we'd only get one argument with an escaped space in it.

Undervolt's flags don't have anything in them that would need to be escaped, so
that shouldn't break anything
@Atemu
Copy link
Member Author

@Atemu Atemu commented Aug 22, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Aug 22, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 21, 2020

@glittershark please review.

Both limit and window must be set.
'';
};
p2.window = mkOption {
Copy link
Member

@glittershark glittershark Oct 22, 2020

just a thought, but we might be able to use a submodule type to deduplicate the window and limit type definitions. But that might be overly abstracted, so I'll leave it up to you / other reviewers

@glittershark
Copy link
Member

@glittershark glittershark commented Oct 22, 2020

/status needs_merger

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 26, 2020

Reminder: Please review!

Reminder: This Pull Request is awaiting merger. If you are the assigned reviewer with commit permission, please have a look. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

Copy link
Member

@timokau timokau left a comment

Thanks @glittershark and @pbogdan for the reviews.

@timokau timokau merged commit 83f48e8 into NixOS:master Oct 30, 2020
16 checks passed
@Atemu
Copy link
Member Author

@Atemu Atemu commented Oct 30, 2020

Thank you!

Should we backport this to 20.09? It already has the undervolt update which allows for this feature.

@timokau
Copy link
Member

@timokau timokau commented Oct 30, 2020

Yes, I think that would be fine, since its purely a feature-addition without risk of breakge. Its not my decision though. I think it would be best to open a backport PR and ping one of the release managers.

@Atemu Atemu deleted the undervolt-pl branch Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants