Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-sexp: Unmark sexp-grammar as broken #95067

Merged
merged 1 commit into from Aug 10, 2020

Conversation

@Munksgaard
Copy link
Contributor

@Munksgaard Munksgaard commented Aug 10, 2020

Mark sexp-grammar as not broken

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Aug 10, 2020

@Munksgaard It looks like sexp-grammar depends on invertible-grammar, so you'll have to mark that as non-broken as well.

Also, I'd suggest changing the commit message to start with haskellPackages.sexp-grammar: instead of haskell-sexp.

@Munksgaard
Copy link
Contributor Author

@Munksgaard Munksgaard commented Aug 10, 2020

@cdepillabout Thanks for the comments, I've pushed a new commit.

@Munksgaard
Copy link
Contributor Author

@Munksgaard Munksgaard commented Aug 10, 2020

I don't understand the error coming from grahamofborg-eval. Do you have any idea what's gone wrong, @cdepillabout?

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Aug 10, 2020

@Munksgaard I wrote a short blog post on this error: https://functor.tokyo/blog/2020-06-02-evaluating-nixpkgs

However this error wasn't caused by this PR, so I think this should probably be okay as-is.

@cdepillabout cdepillabout merged commit 09e83e0 into NixOS:haskell-updates Aug 10, 2020
1 of 3 checks passed
@Munksgaard Munksgaard deleted the haskell-updates branch Aug 10, 2020
@Munksgaard
Copy link
Contributor Author

@Munksgaard Munksgaard commented Aug 10, 2020

Great stuff, thank you @cdepillabout. Do you know how long it usually takes for haskell-updates to be merged into nightly?

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Aug 10, 2020

@Munksgaard peti usually merges it in about once every week or so. If you watch the Haskell tag here in nixpkgs, peti will probably eventually make a PR for merging it in, and that PR will contain the commits here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants