Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-new: Amend upload-image.sh and boot-vm.sh #95279

Closed
wants to merge 1 commit into from

Conversation

@toraritte
Copy link
Contributor

@toraritte toraritte commented Aug 12, 2020

Motivation for this change

This is mainly a request for review (@colemickens , @jonringer ?) as most of the changes are opinionated but hope that there are parts that could be of use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@colemickens
Copy link
Member

@colemickens colemickens commented Aug 12, 2020

Are you on IRC? I've been working on something you might be interested in.

@toraritte
Copy link
Contributor Author

@toraritte toraritte commented Oct 11, 2020

Moved these changes to a separate repo, but more importantly, there is already a more modern implementation of this script using flakes (more info at IRC channel #nixos-azure with logs).

@toraritte toraritte closed this Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants