Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switcheroo-control: init at 2.3 #95337

Merged
merged 2 commits into from Feb 5, 2021
Merged

switcheroo-control: init at 2.3 #95337

merged 2 commits into from Feb 5, 2021

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Aug 13, 2020

Motivation for this change

A service used by GNOME and other desktop environment to offload GPU intensve processes to a secondary GPU.
Fixes #87005 .
Thanks to @jtojnar for their guidance on packaging it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/257

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expression is also somewhat too compact – some spacing like in https://discourse.nixos.org/t/document-attribute-ordering-in-package-expressions/4887 and one meson flag per line would help make it easier to read.

pkgs/os-specific/linux/switcheroo-control/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/switcheroo-control/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/switcheroo-control/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/switcheroo-control/default.nix Outdated Show resolved Hide resolved
description = "D-Bus service to check the availability of dual-GPU";
homepage = "https://gitlab.freedesktop.org/hadess/switcheroo-control/";
changelog = "https://gitlab.freedesktop.org/hadess/switcheroo-control/-/blob/${version}/NEWS";
license = licenses.gpl3Only;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/332

};

nativeBuildInputs = [
ninja meson pkg-config glib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment what is glib needed for? I assume something like glib-mkenums?

@ishan9299
Copy link

What needs to be done to get this merged?

@jtojnar
Copy link
Contributor

jtojnar commented Feb 5, 2021

Sorry, I forgot about this. I have rebased this and fixed the editorconfig errors. Will merge once CI passes.

There has been a new release since but I will merge this as is as that has already been tested and I have no way of testing the new one if I bump it.
https://gitlab.freedesktop.org/hadess/switcheroo-control/-/compare/2.3...2.4

switcheroo-control: addded to package set
node/switcheroo-control: better formatting
@jtojnar
Copy link
Contributor

jtojnar commented Feb 5, 2021

Ugh, missed the editorconfig errors in all-packages.nix

@jtojnar jtojnar merged commit 493bbc9 into NixOS:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switcheroo-control
4 participants