New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switcheroo-control: init at 2.3 #95337
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expression is also somewhat too compact – some spacing like in https://discourse.nixos.org/t/document-attribute-ordering-in-package-expressions/4887 and one meson flag per line would help make it easier to read.
description = "D-Bus service to check the availability of dual-GPU"; | ||
homepage = "https://gitlab.freedesktop.org/hadess/switcheroo-control/"; | ||
changelog = "https://gitlab.freedesktop.org/hadess/switcheroo-control/-/blob/${version}/NEWS"; | ||
license = licenses.gpl3Only; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it is inconsistent https://gitlab.freedesktop.org/hadess/switcheroo-control/-/issues/18
e3ff468
to
7a7012e
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
}; | ||
|
||
nativeBuildInputs = [ | ||
ninja meson pkg-config glib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment what is glib needed for? I assume something like glib-mkenums?
What needs to be done to get this merged? |
Sorry, I forgot about this. I have rebased this and fixed the editorconfig errors. Will merge once CI passes. There has been a new release since but I will merge this as is as that has already been tested and I have no way of testing the new one if I bump it. |
switcheroo-control: addded to package set
node/switcheroo-control: better formatting
Ugh, missed the editorconfig errors in all-packages.nix |
Motivation for this change
A service used by GNOME and other desktop environment to offload GPU intensve processes to a secondary GPU.
Fixes #87005 .
Thanks to @jtojnar for their guidance on packaging it.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)