Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpac: 0.8.0 -> 1.0.0 addressing numerous CVEs #95546

Merged
merged 1 commit into from Sep 7, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Aug 16, 2020

Motivation for this change

Addresses:

CVE-2019-20159
CVE-2019-20160
CVE-2019-20161
CVE-2019-20162
CVE-2019-20163
CVE-2019-20164
CVE-2019-20165
CVE-2019-20166
CVE-2019-20167
CVE-2019-20168
CVE-2019-20169
CVE-2019-20170
CVE-2019-20171
CVE-2019-20208
CVE-2020-11558
CVE-2020-6630
CVE-2020-6631

of mixed severity but at least a couple of them look pretty serious.

For each of these vulnerabilities, the trail leads to a commit included in 1.0.0.

Hopefully we could get a maintainer (@bluescreen303 ? @mgdelacroix ?) to take a look at this because I don't really know how to test it. The executables behave in a very similar (odd) way to the binaries in the previous 0.8.0 package, anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
addressing numerous CVEs
@risicle
Copy link
Contributor Author

@risicle risicle commented Aug 16, 2020

@ofborg eval build gpac

@ofborg ofborg bot requested review from mgdelacroix and bluescreen303 Aug 16, 2020
@worldofpeace worldofpeace merged commit 12a20ce into NixOS:master Sep 7, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gpac, gpac.passthru.tests on aarch64-linux Success
Details
gpac, gpac.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dfdc15"; rev="6dfdc15ac3765e53947f2773c01cc0160ee3d45c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dfdc15"; rev="6dfdc15ac3765e53947f2773c01cc0160ee3d45c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dfdc15"; rev="6dfdc15ac3765e53947f2773c01cc0160ee3d45c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dfdc15"; rev="6dfdc15ac3765e53947f2773c01cc0160ee3d45c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dfdc15"; rev="6dfdc15ac3765e53947f2773c01cc0160ee3d45c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dfdc15"; rev="6dfdc15ac3765e53947f2773c01cc0160ee3d45c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6dfdc15"; rev="6dfdc15ac3765e53947f2773c01cc0160ee3d45c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.