Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flink: 1.9.0 -> 1.11.1, addressing CVE-2020-1960 #95592

Merged
merged 1 commit into from Sep 7, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Aug 16, 2020

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-1960

This is mainly for the eyes of maintainer @mbode to check whether this works acceptably for them. It would be nice to get a bump of the mainline package to as recent a version as possible before 20.09 branches, because future vulnerabilities are unlikely to see releases for older versions.

Note that upstream's 1.5 branch actually has a fix for this CVE @ apache/flink@f9b4e0d, but with no release accompanying it and because this is a binary package, we don't have the possibility of using it as a patch. So it looks like our flink_1_5 will have to remain vulnerable for the time being (this is why binary packages make me sad).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
addressing CVE-2020-1960
@worldofpeace worldofpeace merged commit 53ce0bf into NixOS:master Sep 7, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
flink, flink.passthru.tests on aarch64-linux Success
Details
flink, flink.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67326df"; rev="67326dfbe8d2fc00f4e80cb9238a9afbce46ec37"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67326df"; rev="67326dfbe8d2fc00f4e80cb9238a9afbce46ec37"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67326df"; rev="67326dfbe8d2fc00f4e80cb9238a9afbce46ec37"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67326df"; rev="67326dfbe8d2fc00f4e80cb9238a9afbce46ec37"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67326df"; rev="67326dfbe8d2fc00f4e80cb9238a9afbce46ec37"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67326df"; rev="67326dfbe8d2fc00f4e80cb9238a9afbce46ec37"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67326df"; rev="67326dfbe8d2fc00f4e80cb9238a9afbce46ec37"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.