Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-vanity-hash: init at 2020-02-26 #95717

Merged
merged 1 commit into from Oct 18, 2020
Merged

git-vanity-hash: init at 2020-02-26 #95717

merged 1 commit into from Oct 18, 2020

Conversation

@KAction
Copy link
Contributor

@KAction KAction commented Aug 17, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Content:

├── bin
│   └── git-vanity-hash
└── share
    └── doc
        └── git-vanity-hash
            └── README.md

4 directories, 2 files

Closure size:

/nix/store/70g14lxdfi420w8mxnqdrwqksnrfdkxi-git-vanity-hash-unstable-2020-02-26	   33510144
@maxxk
Copy link
Contributor

@maxxk maxxk commented Aug 18, 2020

Works for me:

$ git-vanity-hash find cafe
Found hash: cafea47ad24a44f3a597bed4926a3bf3dba5e3a9

$ git-vanity-hash find beef
Found hash: beef53bfef9cf61c460f75f1441979879697f1aa

$ git-vanity-hash find feed
Found hash: feed66c97bfba4858e07a3acc8904220a0521f0e

raboof
raboof approved these changes Aug 30, 2020

meta = with stdenv.lib; {
homepage = "https://github.com/prasmussen/git-vanity-hash";
description = "tool for creating commit hashes with a specific prefix";
Copy link
Member

@raboof raboof Aug 30, 2020

Suggested change
description = "tool for creating commit hashes with a specific prefix";
description = "Tool for creating commit hashes with a specific prefix";

@KAction KAction force-pushed the git-vanity-hash branch from 1776fe1 to 01c3f58 Aug 30, 2020
@KAction
Copy link
Contributor Author

@KAction KAction commented Aug 30, 2020

Applied.

@KAction
Copy link
Contributor Author

@KAction KAction commented Oct 7, 2020

Ping? What is missing for merging?

@KAction
Copy link
Contributor Author

@KAction KAction commented Oct 17, 2020

@ryantm Can you please merge this?

@KAction KAction force-pushed the git-vanity-hash branch from 01c3f58 to c004bca Oct 17, 2020
@ryantm
Copy link
Member

@ryantm ryantm commented Oct 18, 2020

Result of nixpkgs-review pr 95717 1

1 package built:
- gitAndTools.git-vanity-hash

@ryantm ryantm merged commit 396f340 into NixOS:master Oct 18, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c004bca"; rev="c004bcab9ca439418fe2fc605d2b1f3eec4e5535"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c004bca"; rev="c004bcab9ca439418fe2fc605d2b1f3eec4e5535"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c004bca"; rev="c004bcab9ca439418fe2fc605d2b1f3eec4e5535"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c004bca"; rev="c004bcab9ca439418fe2fc605d2b1f3eec4e5535"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c004bca"; rev="c004bcab9ca439418fe2fc605d2b1f3eec4e5535"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c004bca"; rev="c004bcab9ca439418fe2fc605d2b1f3eec4e5535"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c004bca"; rev="c004bcab9ca439418fe2fc605d2b1f3eec4e5535"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants