Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatcam: init at 8.5 #95734

Merged
merged 1 commit into from Sep 16, 2020
Merged

flatcam: init at 8.5 #95734

merged 1 commit into from Sep 16, 2020

Conversation

@trepetti
Copy link
Contributor

trepetti commented Aug 18, 2020

Motivation for this change

FlatCAM is a software for 2D design postprocessing for manufacturing focusing on fabricating PCB designs on CNC routers. The software lets users take Gerber and Excellon files (industry standard PCB layer information files) and converts them to gcode to be executed on a CNC. Nix already has many PCB and CNC packages available, and this one fills in a gap.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

nixos-discourse commented Aug 22, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/262

@trepetti
Copy link
Contributor Author

trepetti commented Aug 22, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 22, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@trepetti
Copy link
Contributor Author

trepetti commented Aug 22, 2020

Apologies for the close and reopen. It was the GitHub mobile app equivalent of a buttdial.

@trepetti trepetti changed the title flatcam: init at 8.993 flatcam: init at 8.5 Aug 25, 2020
@trepetti trepetti force-pushed the trepetti:flatcam branch from 9463eac to e41904b Aug 25, 2020
Copy link
Contributor

symphorien left a comment

Overall, this looks good, thanks!
I left a few comments, but they are no blocker.

@symphorien
Copy link
Contributor

symphorien commented Aug 29, 2020

/status awaiting_changes

@trepetti trepetti force-pushed the trepetti:flatcam branch from da13dc3 to 10e5003 Sep 3, 2020
@trepetti
Copy link
Contributor Author

trepetti commented Sep 3, 2020

I have a pending PR with those fixes up-stream. That beta branch I mentioned too may not be merged anytime soon but adds some cool features (and also drops Qt4, which I know Nix will be doing soon too). I will package it separately as flatcam-beta.

@nixos-discourse
Copy link

nixos-discourse commented Sep 14, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/224

@AndersonTorres AndersonTorres merged commit 811709f into NixOS:master Sep 16, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
flatcam, flatcam.passthru.tests on aarch64-linux Success
Details
flatcam, flatcam.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10e5003"; rev="10e5003d200f4763ccd3122b22be3706cdfb74b9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10e5003"; rev="10e5003d200f4763ccd3122b22be3706cdfb74b9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10e5003"; rev="10e5003d200f4763ccd3122b22be3706cdfb74b9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10e5003"; rev="10e5003d200f4763ccd3122b22be3706cdfb74b9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10e5003"; rev="10e5003d200f4763ccd3122b22be3706cdfb74b9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10e5003"; rev="10e5003d200f4763ccd3122b22be3706cdfb74b9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="10e5003"; rev="10e5003d200f4763ccd3122b22be3706cdfb74b9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@trepetti trepetti deleted the trepetti:flatcam branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.