Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crispy-doom: upgrade 5.8.0 -> 5.9.2 + add manpages #95996

Merged
merged 2 commits into from Oct 4, 2020

Conversation

@neonfuz
Copy link
Contributor

@neonfuz neonfuz commented Aug 22, 2020

Motivation for this change

Version bump. While doing the version bump I realized manpages were failing to build because python was a missing build dependency, so I added that too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@neonfuz
Copy link
Contributor Author

@neonfuz neonfuz commented Sep 23, 2020

Upstream upgraded to 5.9.2, so I pushed another update

@neonfuz neonfuz changed the title crispy-doom: upgrade 5.8.0 -> 5.9.0 + add manpages crispy-doom: upgrade 5.8.0 -> 5.9.2 + add manpages Sep 23, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 2, 2020

Result of nixpkgs-review pr 95996 1

1 package built:
  • crispyDoom
@neonfuz neonfuz force-pushed the neonfuz:crispy-doom branch from 83e387a to 6abdcac Oct 3, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 3, 2020

Can you rebase this? I'm getting an odd error during nixpkgs-review.

builder for '/nix/store/61f1rkkvw1bnkx30nd4wilqyw9v3awkk-crispy-doom-5.9.2.drv' failed with exit code 1; last 6 log lines:
  unpacking sources
  unpacking source archive /nix/store/rpwp850rqim6c9b3wr4v5qrvjmlc6ca8-source
  source root is source
  patching sources
  /nix/store/333six1faw9bhccsx9qw5718k6b1wiq2-stdenv-linux/setup: eval: line 83: syntax error: unexpected end of file
  builder for '/nix/store/61f1rkkvw1bnkx30nd4wilqyw9v3awkk-crispy-doom-5.9.2.drv' failed with exit code 2
cannot build derivation '/nix/store/6m02m5g1fa99a6rf8j9lj60416y7rv89-env.drv': 1 dependencies couldn't be built
@neonfuz neonfuz force-pushed the neonfuz:crispy-doom branch from 6abdcac to 4818d0c Oct 3, 2020
@neonfuz
Copy link
Contributor Author

@neonfuz neonfuz commented Oct 4, 2020

Okay odd, I rebased it onto master and I'm getting the same error. Some dependency must have changed and broke the build. I'll look into it...

@neonfuz neonfuz force-pushed the neonfuz:crispy-doom branch from 4818d0c to e507c77 Oct 4, 2020
@neonfuz
Copy link
Contributor Author

@neonfuz neonfuz commented Oct 4, 2020

Okay it was my mistake, I missed a semicolon when squashing the lines down in my script. Fixed and pushed.

@mweinelt mweinelt merged commit 57a9fc1 into NixOS:master Oct 4, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e507c77"; rev="e507c77a7d846e1b63f6b319b130db8419fd4d20"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e507c77"; rev="e507c77a7d846e1b63f6b319b130db8419fd4d20"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e507c77"; rev="e507c77a7d846e1b63f6b319b130db8419fd4d20"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e507c77"; rev="e507c77a7d846e1b63f6b319b130db8419fd4d20"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e507c77"; rev="e507c77a7d846e1b63f6b319b130db8419fd4d20"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e507c77"; rev="e507c77a7d846e1b63f6b319b130db8419fd4d20"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e507c77"; rev="e507c77a7d846e1b63f6b319b130db8419fd4d20"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@neonfuz neonfuz deleted the neonfuz:crispy-doom branch Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.