Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.fx: init at 19.0.1 #96189

Closed
wants to merge 1 commit into from
Closed

Conversation

@elkowar
Copy link
Contributor

@elkowar elkowar commented Aug 24, 2020

Motivation for this change

fx is a command-line utility for json processing and viewing.
It allows you to interactively look at json data, as well as process json data simmilarly to jq

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@deviant
Copy link
Member

@deviant deviant commented Aug 31, 2020

Was about to package fx myself, then spotted this. cherry-picked; works nicely. +1 on this being added

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 27, 2020

looks good to go, it just needs a rebase to fix the merge conflict

@deviant
Copy link
Member

@deviant deviant commented Sep 29, 2020

It also needs updating again; there's been a new release since this PR was made.

@deviant
Copy link
Member

@deviant deviant commented Oct 17, 2020

Since this hasn't been touched in almost two months, I made a new PR that replaces it.

@zimbatm zimbatm closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants