Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing/adding python27 derivations #96262

Closed
wants to merge 1 commit into from

Conversation

@jpgu-epam
Copy link

@jpgu-epam jpgu-epam commented Aug 25, 2020

Motivation for this change

As the channel keeps supporting python27 some derivations need to be fixed or added to still working is this python version.

Things done
  • Add python27 support for the following derivations:

    GitPython
    Venusian
    Uritools
    Sphinxcontrib-blockdiag

  • Adding Protobuf 3.3.0 derivation

  • Fix tremor repository which was moved to GitLab

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
* Venusian: add python2 support.
* Uritools: add python2 support.
* Sphinxcontrib-blockdiag: add python2 support.
* Protobuf: add 3.3.0 version derivation
* Tremor: Fix repository which was moved to GitLab
@jpgu-epam jpgu-epam requested review from FRidh and jonringer as code owners Aug 25, 2020
Copy link
Member

@FRidh FRidh left a comment

Thanks. One commit per change though. In this case that would mean one commit per package.

@@ -7038,3 +7048,4 @@ in {
});

in fix' (extends overrides packages)
Copy link
Member

@FRidh FRidh Aug 25, 2020

please undo this change

@jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 25, 2020

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Due to the number of PRs nixpkgs gets every month we didn't review and merge this on in time before 20.03 hit EOL. If you think this PR is still relevant please rebase it on master or 20.09 and leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants