Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv/native: provide patchelf on linux #96318

Merged

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Aug 25, 2020

This provides consistency with the pure stdenv, which provides
patchelf this way. Native stdenv can always just manually install
patchelf on their system, but like xz, it’s unlikely to be provided in
/usr/bin/. In addition, it’s not even in the RHEL7 repos.

Still wip, because i need a chance to test it on my setup; it's a mass rebuild :(

This provides consistency with the pure stdenv, which provides
patchelf this way. Native stdenv can always just manually install
patchelf on their system, but like xz, it’s unlikely to be provided in
/usr/bin/. In addition, it’s not even in the RHEL7 repos.
@matthewbauer matthewbauer requested a review from Ericson2314 as a code owner Aug 26, 2020
@ryantm ryantm marked this pull request as draft Oct 23, 2020
@matthewbauer matthewbauer changed the title [wip] stdenv/native: provide patchelf on linux stdenv/native: provide patchelf on linux Oct 30, 2020
@matthewbauer matthewbauer marked this pull request as ready for review Oct 30, 2020
@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented Oct 30, 2020

Looks to be merge. The PR shouldn't interfere with any existing native stdenv, since we already have patchelf built.

@matthewbauer matthewbauer merged commit 989b403 into NixOS:master Oct 30, 2020
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant