Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmesode: Add a patch from upstream to fix SSL verification #96486

Merged
merged 1 commit into from Oct 13, 2020

Conversation

@wahjava
Copy link
Contributor

@wahjava wahjava commented Aug 27, 2020

Motivation for this change

SSL certificate verification in profanity (libmesode consumer) does not work because NixOS ships CA certificates in a file. The upstream profanity-im/libmesode@532ed1e fixes this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@devhell devhell left a comment

Excellent! Thanks for this! 😀

@wahjava
Copy link
Contributor Author

@wahjava wahjava commented Oct 11, 2020

What does one need to get this merged ? Just curious, as I'm maintaining an overlay in my local configuration for this. :)

Thanks!

@Lassulus Lassulus merged commit 629fb94 into NixOS:master Oct 13, 2020
18 checks passed
@wahjava wahjava deleted the fix-profanity branch Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants