Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expo-cli: init + implement overrideNodeAttrs #96509

Merged
merged 2 commits into from Oct 7, 2020
Merged

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 27, 2020

Motivation for this change

Closes: #93399

Had to implement overrideNodeAttrs to filter out optional @expo/traveling-fastlane-darwin dependency that was intentionally aborting the build on Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Successfully ran react-native app on Android using this
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Aug 27, 2020

cc @FRidh who implemented overridePythonAttrs I based this on

cc @Scriptkiddi who was also interested in this

@FRidh
Copy link
Member

@FRidh FRidh commented Aug 28, 2020

While I am not sure whether it is the correct direction to add these language/framework-specific overrides (see NixOS/rfcs#67 (comment)) I do think the implementation in #87394 would be preferred over us implementing our own ones every time.

@jtojnar jtojnar force-pushed the jtojnar:expo-cli branch from 58d915a to 6891520 Aug 28, 2020
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Aug 28, 2020

Thanks, I was trying to find the PR but did not realize it was closed. I agree with you but in the meantime I would like a working, if only temporary solution.

What do you think about gating it on explicit acknowledgement that the function can be dropped at any time?

@FRidh
Copy link
Member

@FRidh FRidh commented Aug 29, 2020

Well, I say we should just use that PR. Having those override functions does not preclude having a common override function which I proposed (that could be say overrideArgs).

jtojnar added 2 commits Aug 27, 2020
mimicking the buildPythonPackage's overridePythonAttrs function
@jtojnar jtojnar force-pushed the jtojnar:expo-cli branch from ab0dd3d to 6d7aafc Oct 7, 2020
@ofborg ofborg bot requested a review from midchildan Oct 7, 2020
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Oct 7, 2020

I think I will use the local internal function for now, rather than switching to a public API that would be deprecated after RFC 67. I will port to that once it gets accepted.

@jtojnar jtojnar merged commit b762081 into NixOS:master Oct 7, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d7aafc"; rev="6d7aafccbf9d9f6863d620e1a4378cd5aac8524e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d7aafc"; rev="6d7aafccbf9d9f6863d620e1a4378cd5aac8524e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d7aafc"; rev="6d7aafccbf9d9f6863d620e1a4378cd5aac8524e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d7aafc"; rev="6d7aafccbf9d9f6863d620e1a4378cd5aac8524e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d7aafc"; rev="6d7aafccbf9d9f6863d620e1a4378cd5aac8524e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d7aafc"; rev="6d7aafccbf9d9f6863d620e1a4378cd5aac8524e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d7aafc"; rev="6d7aafccbf9d9f6863d620e1a4378cd5aac8524e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the jtojnar:expo-cli branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.