Skip to content

noaa-apt: init at 1.2.0#96519

Merged
danieldk merged 1 commit into
NixOS:masterfrom
trepetti:noaa-apt
Aug 29, 2020
Merged

noaa-apt: init at 1.2.0#96519
danieldk merged 1 commit into
NixOS:masterfrom
trepetti:noaa-apt

Conversation

@trepetti
Copy link
Copy Markdown
Contributor

@trepetti trepetti commented Aug 28, 2020

Motivation for this change

noaa-apt is decoding software that enables the conversion of audio recordings of NOAA weather satellite APT protocol transmissions into a variety of image formats. Typically this recording is done using software defined radios (SDRs) like RTLSDR, HackRF, etc., which are already well supported in Nix. This software would complement the growing suite of SDR tools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@trepetti
Copy link
Copy Markdown
Contributor Author

trepetti commented Aug 28, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link
Copy Markdown

marvin-mk2 Bot commented Aug 28, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 28, 2020
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Aug 29, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/278

danieldk
danieldk suggested changes Aug 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added a number of small requested changes.

Comment thread pkgs/applications/radio/noaa-apt/default.nix Outdated
Comment thread pkgs/applications/radio/noaa-apt/default.nix Outdated
Comment thread pkgs/top-level/all-packages.nix Outdated
Comment thread pkgs/applications/radio/noaa-apt/default.nix Outdated
Comment thread pkgs/applications/radio/noaa-apt/default.nix Outdated
Comment thread pkgs/applications/radio/noaa-apt/default.nix Outdated
@trepetti trepetti requested a review from danieldk August 29, 2020 14:38
@trepetti
Copy link
Copy Markdown
Contributor Author

trepetti commented Aug 29, 2020

Thank you for your review! I believe this covers all those fixes.

danieldk
danieldk approved these changes Aug 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making all the changes!

Result of nixpkgs-review pr 96519 1

1 package built:
- noaa-apt

@danieldk danieldk merged commit d37baf7 into NixOS:master Aug 29, 2020
@trepetti trepetti deleted the noaa-apt branch August 29, 2020 15:17
@trepetti trepetti mentioned this pull request Oct 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danieldk danieldk danieldk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trepetti @nixos-discourse @danieldk