Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aribb25: init at 0.2.7 #96553

Merged
merged 2 commits into from Oct 4, 2020
Merged

aribb25: init at 0.2.7 #96553

merged 2 commits into from Oct 4, 2020

Conversation

@midchildan
Copy link
Contributor

@midchildan midchildan commented Aug 28, 2020

Motivation for this change

Add aribb25, a sample implementation of the ARIB STD-B25 standard.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@midchildan
Copy link
Contributor Author

@midchildan midchildan commented Aug 28, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Aug 28, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Aug 28, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Copy link
Contributor

@AluisioASG AluisioASG left a comment

Builds and seems to run once rev is corrected.

@@ -4583,7 +4583,7 @@ in

isync = callPackage ../tools/networking/isync { };

itm-tools = callPackage ../development/tools/misc/itm-tools { };

This comment has been minimized.

@AluisioASG

AluisioASG Oct 1, 2020
Contributor

There's a bunch of extraneous whitespace cleaning in this file.

This comment has been minimized.

@midchildan

midchildan Oct 2, 2020
Author Contributor

Seems to be the project's .editorconfig doing its thing.

trim_trailing_whitespace = true

I think it might be better to separate the commit and keep it as-is because other contributors who also have editorconfig enabled are also going to run into this anyways.

This comment has been minimized.

@midchildan

midchildan Oct 2, 2020
Author Contributor

I did a rebase to fix merge conflicts, and it seems the whitespace issues are now gone.

pkgs/development/libraries/aribb25/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/aribb25/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/aribb25/default.nix Outdated Show resolved Hide resolved
@midchildan midchildan force-pushed the midchildan:add-aribb25 branch from 6283ce8 to fec8ae5 Oct 2, 2020
@AluisioASG
Copy link
Contributor

@AluisioASG AluisioASG commented Oct 2, 2020

/status needs_merger

@marvin-mk2 marvin-mk2 bot added needs_merger and removed awaiting_reviewer labels Oct 2, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau Oct 2, 2020
@marvin-mk2 marvin-mk2 bot added awaiting_merger and removed needs_merger labels Oct 2, 2020
buildInputs = if stdenv.isDarwin then [ PCSC ] else [ pcsclite ];

patches = let
url = pr: "https://code.videolan.org/videolan/${pname}/-/merge_requests/${pr}.patch";

This comment has been minimized.

@timokau

timokau Oct 2, 2020
Member

This type of patch is unstable, it might change when the MR changes. That would then break the fixed-output-derivation. You should refer to the relevant commits directly instead.

This comment has been minimized.

@midchildan

midchildan Oct 3, 2020
Author Contributor

Fixed.

@midchildan
Copy link
Contributor Author

@midchildan midchildan commented Oct 3, 2020

I also fixed the build for macOS.

patches = let
url = commit: "https://code.videolan.org/videolan/${pname}/-/commit/${commit}.diff";
in [
(fetchpatch {

This comment has been minimized.

@timokau

timokau Oct 4, 2020
Member

One minor nit: Its always nice to give a few words of explanation and/or an upstream PR link in a comment. This information probably got lost on accident when you switched from PR-patch to commits. Its not worth another review iteration, just for the future :)

@timokau
timokau approved these changes Oct 4, 2020
Copy link
Member

@timokau timokau left a comment

Thank you, and thanks @AluisioASG for the review!

@timokau timokau merged commit 8129b1d into NixOS:master Oct 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
aribb25, aribb25.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
aribb25, aribb25.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="954cf07"; rev="954cf0795c743722632d4bb23914b3d1283f03a7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="954cf07"; rev="954cf0795c743722632d4bb23914b3d1283f03a7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="954cf07"; rev="954cf0795c743722632d4bb23914b3d1283f03a7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="954cf07"; rev="954cf0795c743722632d4bb23914b3d1283f03a7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="954cf07"; rev="954cf0795c743722632d4bb23914b3d1283f03a7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="954cf07"; rev="954cf0795c743722632d4bb23914b3d1283f03a7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="954cf07"; rev="954cf0795c743722632d4bb23914b3d1283f03a7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@midchildan midchildan deleted the midchildan:add-aribb25 branch Oct 4, 2020
siraben added a commit to siraben/nixpkgs that referenced this pull request Oct 5, 2020
* aribb25: init at 0.2.7

* fixup! aribb25: init at 0.2.7
dawidsowa added a commit to dawidsowa/nixpkgs that referenced this pull request Oct 11, 2020
* aribb25: init at 0.2.7

* fixup! aribb25: init at 0.2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.