Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlightenment.efl: add needed libraries #96559

Merged
merged 1 commit into from Sep 4, 2020
Merged

enlightenment.efl: add needed libraries #96559

merged 1 commit into from Sep 4, 2020

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Aug 28, 2020

Motivation for this change

Some libraries are linked at runtime by hand in code (they are dlopened) in EFL and their path need to be hard coded.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Aug 31, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/281

@romildo
Copy link
Contributor Author

@romildo romildo commented Sep 4, 2020

This fix makes applications more stable. Terminology was crashing with some applications, like vim for instance.
Merging.

@romildo romildo merged commit 28d7bc1 into NixOS:master Sep 4, 2020
18 of 19 checks passed
18 of 19 checks passed
action
Details
enlightenment.efl, enlightenment.efl.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
enlightenment.efl, enlightenment.efl.passthru.tests on aarch64-linux Success
Details
enlightenment.efl, enlightenment.efl.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b629c01"; rev="b629c017040a8d18607cb5e806b48df118aa1fef"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b629c01"; rev="b629c017040a8d18607cb5e806b48df118aa1fef"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b629c01"; rev="b629c017040a8d18607cb5e806b48df118aa1fef"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b629c01"; rev="b629c017040a8d18607cb5e806b48df118aa1fef"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b629c01"; rev="b629c017040a8d18607cb5e806b48df118aa1fef"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b629c01"; rev="b629c017040a8d18607cb5e806b48df118aa1fef"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b629c01"; rev="b629c017040a8d18607cb5e806b48df118aa1fef"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@romildo romildo deleted the romildo:fix.efl branch Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.