Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/samba: remove upstream deprecated syncPasswordsByPam option #96672

Merged
merged 1 commit into from Oct 4, 2020

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Aug 30, 2020

Motivation for this change

Resolve / Fix #54492 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar doronbehar merged commit 9544c60 into NixOS:master Oct 4, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cd4d59"; rev="8cd4d59a329c147a832b5aabd1484d2f31a1621e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cd4d59"; rev="8cd4d59a329c147a832b5aabd1484d2f31a1621e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cd4d59"; rev="8cd4d59a329c147a832b5aabd1484d2f31a1621e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cd4d59"; rev="8cd4d59a329c147a832b5aabd1484d2f31a1621e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cd4d59"; rev="8cd4d59a329c147a832b5aabd1484d2f31a1621e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cd4d59"; rev="8cd4d59a329c147a832b5aabd1484d2f31a1621e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cd4d59"; rev="8cd4d59a329c147a832b5aabd1484d2f31a1621e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Oct 4, 2020
This reverts commit 9544c60, reversing
changes made to c12b9cd.
@eadwu
Copy link
Member

@eadwu eadwu commented Oct 4, 2020

You missed a section

      ${optionalString config.services.samba.syncPasswordsByPam
        "mr ${pkgs.samba}/lib/security/pam_smbpass.so,"}
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Oct 4, 2020
This reverts commit 9544c60, reversing
changes made to c12b9cd.
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Oct 5, 2020
This reverts commit 9544c60, reversing
changes made to c12b9cd.
@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Oct 5, 2020

@eadwu what did I miss? git grep syncPasswordsByPam lists only the line with mkRemovedOptionModule.

NeQuissimus added a commit to NeQuissimus/nixpkgs that referenced this pull request Oct 5, 2020
9544c60 / NixOS#96672 removed the samba option
`syncPasswordsByPam`.
Need to remove this option from the pam module, otherwise it will cause build errors
@NeQuissimus NeQuissimus mentioned this pull request Oct 5, 2020
5 of 10 tasks complete
eadwu added a commit to eadwu/nixpkgs that referenced this pull request Oct 5, 2020
This reverts commit 9544c60, reversing
changes made to c12b9cd.
dawidsowa added a commit to dawidsowa/nixpkgs that referenced this pull request Oct 11, 2020
9544c60 / NixOS#96672 removed the samba option
`syncPasswordsByPam`.
Need to remove this option from the pam module, otherwise it will cause build errors
Luz added a commit to Luz/nixpkgs that referenced this pull request Nov 5, 2020
9544c60 / NixOS#96672 removed the samba option
`syncPasswordsByPam`.
Need to remove this option from the pam module, otherwise it will cause build errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.