Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware-horizon-client: init at 2006 #96849

Merged
merged 1 commit into from Oct 8, 2020
Merged

Conversation

@buckley310
Copy link
Contributor

@buckley310 buckley310 commented Aug 31, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 31, 2020

1 similar comment
@jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 31, 2020

@das-g
Copy link
Member

@das-g das-g commented Aug 31, 2020

Result of nixpkgs-review pr 96849 1

1 package built:
- vmware-horizon-client

@das-g
Copy link
Member

@das-g das-g commented Aug 31, 2020

I can use the resulting vmware-view executable to connect to vdi.hsr.ch (which uses a SWIVEL 2nd factor) and start a desktop session there. However, when I try to connect to vdi.rj.ost.ch (which uses Microsoft login with mandatory 2nd factor), it fails with

2020-08-31 22:52:54.612+02:00: vmware-view 7937| udpProxyLib: FECHostSocket_Specialise: failed to get desired receive bufsize: 425984, errno 115

2020-08-31 22:52:54.612+02:00: vmware-view 7937| udpProxyLib: socket 102 transition to state SYN_SENT, reason FECSocketDoConnect refCount 4

2020-08-31 22:52:54.627+02:00: vmware-view 7937| udpProxyLib: socket 102 transition to state CLOSED, reason FECSocketDoClose refCount 6

2020-08-31 22:52:54.627+02:00: vmware-view 7937| udpProxyLib: FECSocketDestroy: Destroying listen socket 102

XPCOMGlueLoad error for file /nix/store/2xhs6qbip2j1sdhqpl0iaw11r4jfl32d-firefox-unwrapped-79.0/lib/firefox/libmozsandbox.so:
/usr/lib/vmware/gcc/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /nix/store/2xhs6qbip2j1sdhqpl0iaw11r4jfl32d-firefox-unwrapped-79.0/lib/firefox/libmozsandbox.so)
Couldn't load XPCOM.
2020-08-31 22:52:55.629+02:00: vmware-view 7937| TaskCombiner: Removing left CdkGetLaunchItemsTask(DEAD) from combiner.
2020-08-31 22:52:55.629+02:00: vmware-view 7937| TaskCombiner: Removing left CdkGetTunnelConnectionTask(DEAD) from combiner.
2020-08-31 22:52:55.629+02:00: vmware-view 7937| TaskCombiner: Removing left CdkGetTunnelConnectionTask(DEAD) from combiner.
2020-08-31 22:52:55.629+02:00: vmware-view 7937| TaskCombiner: Removing left CdkGetUserGlobalPreferencesTask(DEAD) from combiner.
2020-08-31 22:52:55.629+02:00: vmware-view 7937| TaskCombiner: Removing left CdkGetUserGlobalPreferencesTask(DEAD) from combiner.
2020-08-31 22:52:55.629+02:00: vmware-view 7937| TaskCombiner: Removing left CdkGetLaunchItemsTask(DEAD) from combiner.
2020-08-31 22:52:55.629+02:00: vmware-view 7937| TaskCombiner: Combiner have 6 items left when it is freed.

(This is within the session launched by nixpkgs-review pr 96849. Maybe it works better when properly installed?)

@buckley310
Copy link
Contributor Author

@buckley310 buckley310 commented Aug 31, 2020

I get the same issue when connecting to that server, and my system is running off this branch right now.
Looks like in that case it's trying to launch firefox to handle authentication and firefox doesn't have what it needs inside the FhsUserEnv... I could just add firefox as a dependency, but I'm not sure if running firefox in there will cause trouble (primarily what happens if someone starts using that copy of firefox without knowing it was launched weird). I will give this issue a good look when I get a minute.

@buckley310
Copy link
Contributor Author

@buckley310 buckley310 commented Sep 1, 2020

Even after I make firefox happy, and horizon launches firefox successfully, horizon still crashes after. Not sure why at this point.

@buckley310
Copy link
Contributor Author

@buckley310 buckley310 commented Sep 1, 2020

Actually, when I tested this on Ubuntu, the client also exited after launching the browser, so I'm thinking this is intended behavior. I pushed the fix that makes firefox run properly, but beyond that I cannot test or debug the login process, as I do not have access to any SAML-enabled horizon environment. Can you see what happens now?

@fabianhauser
Copy link
Member

@fabianhauser fabianhauser commented Sep 2, 2020

I checked and the behaviour that vmware-view exits is intended - after successful login, the browser redirects to the url vmware-view://vdi.rj.ost.ch/?useExisting=false&SAMLart=some-private-token-which-i-removed-here, which opens vmware-view on Ubuntu. I suppose this url should be registered with xdg somehow?

@buckley310 buckley310 force-pushed the vmwareview branch 2 times, most recently from d9424c3 to 8519051 Sep 2, 2020
@buckley310
Copy link
Contributor Author

@buckley310 buckley310 commented Sep 2, 2020

I added the scheme handler, and now the vmware-view:// links activate the vmware client for me.

das-g
das-g approved these changes Sep 3, 2020
@das-g
Copy link
Member

@das-g das-g commented Sep 3, 2020

Result of nixpkgs-review pr 96849 1

1 package built:
- vmware-horizon-client

@buckley310
Copy link
Contributor Author

@buckley310 buckley310 commented Sep 17, 2020

Just rebased on 441a7da, no code changes.

@buckley310
Copy link
Contributor Author

@buckley310 buckley310 commented Sep 17, 2020

Replaced some package name aliases with corresponding real names. Should pass ofborg tests now.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 6, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/242

@AndersonTorres AndersonTorres merged commit fab168d into NixOS:master Oct 8, 2020
19 checks passed
@buckley310 buckley310 deleted the vmwareview branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants