Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f3d: init at 1.0.1 #96934

Merged
merged 1 commit into from Oct 10, 2020
Merged

f3d: init at 1.0.1 #96934

merged 1 commit into from Oct 10, 2020

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Sep 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/applications/graphics/f3d/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/f3d/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/f3d/default.nix Outdated Show resolved Hide resolved
@bcdarwin bcdarwin force-pushed the bcdarwin:f3d branch from 1f790cd to c0df231 Sep 2, 2020
@bcdarwin bcdarwin requested a review from OPNA2608 Sep 2, 2020
@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Sep 3, 2020

LGTM if it runs for you.

Tested on non-NixOS Linux (Ubuntu 18.04). SIGABRTs on startup due to libGL, LD_LIBRARY_PATHing the system's libGL libraries works (afaik this is a known problem, see #9415). Not tested with any 3D model.
image

@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented Sep 3, 2020

I have opened some 3d models and it works fine (except that it's compiled without the -r flag for ray tracing due to VTK not being compiled with necessary support). Same issue on non-NixOS Linux, but works on OS X.

@marsam marsam merged commit 69b0cf2 into NixOS:master Oct 10, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
f3d, f3d.passthru.tests on aarch64-linux Success
Details
f3d, f3d.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0df231"; rev="c0df23122ef74d3c8c1d9a24fa56a1f3a1bcc5a4"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0df231"; rev="c0df23122ef74d3c8c1d9a24fa56a1f3a1bcc5a4"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0df231"; rev="c0df23122ef74d3c8c1d9a24fa56a1f3a1bcc5a4"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0df231"; rev="c0df23122ef74d3c8c1d9a24fa56a1f3a1bcc5a4"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0df231"; rev="c0df23122ef74d3c8c1d9a24fa56a1f3a1bcc5a4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0df231"; rev="c0df23122ef74d3c8c1d9a24fa56a1f3a1bcc5a4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0df231"; rev="c0df23122ef74d3c8c1d9a24fa56a1f3a1bcc5a4"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bcdarwin bcdarwin deleted the bcdarwin:f3d branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.