Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gstreamer: remove legacy version #96939

Merged
merged 9 commits into from Sep 4, 2020
Merged

gstreamer: remove legacy version #96939

merged 9 commits into from Sep 4, 2020

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 2, 2020

Motivation for this change

It has been abandoned and insecure for ages. Now it has finally broke so no one should complain.

Fixes: #39975

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
jtojnar added 3 commits Sep 2, 2020
They have been broken and disabled for ages and now the dependencies are being removed.
It is insecure and broken.

Follow #93398
it is insecure and broken
@jtojnar jtojnar added this to the 20.09 milestone Sep 2, 2020
@jtojnar jtojnar added this to To do in Picking up garbage via automation Sep 2, 2020
@ofborg ofborg bot added the 6.topic: steam label Sep 2, 2020
previously it was using the legacy one
@jtojnar jtojnar force-pushed the jtojnar:drop-gst-010 branch 5 times, most recently from cccfbad to 693557e Sep 2, 2020
jtojnar added 5 commits Sep 2, 2020
- use pkg-config instead of pkgconfig alias
- use placeholders for cmakeFlags
- do not skip build rpath
- udev replacements no longer apply TheImagingSource/tiscamera@47d4fb2

There are some misplaced dependencies like gobject-introspection and orc that should probably go to nativeBuildInputs but upstream detects them incorrectly.
It has been abandoned for ages, insecure, and now finally broken.
@jtojnar jtojnar force-pushed the jtojnar:drop-gst-010 branch from 693557e to 4a4e642 Sep 2, 2020
@ofborg ofborg bot added the 8.has: clean-up label Sep 2, 2020
@ofborg ofborg bot requested review from proteansec, markus1189 and jraygauthier Sep 2, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Sep 2, 2020

Lol, and hopefully we could actually have the gstreamer packages not under a weird attribute (eventually). Yay to this

@jtojnar jtojnar merged commit 5079e1c into NixOS:master Sep 4, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
googleearth, googleearth.passthru.tests, gst_all_1.gst-validate, gst_all_1.gst-validate.passthru.tests, qt4, qt4.passthru.tests, steam-run, steam-run.passthru.tests, tiscamera, tiscamera.passthru.tests, webcamoid, webcamoid.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
googleearth, googleearth.passthru.tests, gst_all_1.gst-validate, gst_all_1.gst-validate.passthru.tests, qt4, qt4.passthru.tests, steam-run, steam-run.passthru.tests, tiscamera, tiscamera.passthru.tests, webcamoid, webcamoid.passthru.tests on aarch64-linux Success
Details
googleearth, googleearth.passthru.tests, gst_all_1.gst-validate, gst_all_1.gst-validate.passthru.tests, qt4, qt4.passthru.tests, steam-run, steam-run.passthru.tests, tiscamera, tiscamera.passthru.tests, webcamoid, webcamoid.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a4e642"; rev="4a4e642abaaa026b55f42248a7bb11945ce54607"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a4e642"; rev="4a4e642abaaa026b55f42248a7bb11945ce54607"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a4e642"; rev="4a4e642abaaa026b55f42248a7bb11945ce54607"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a4e642"; rev="4a4e642abaaa026b55f42248a7bb11945ce54607"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a4e642"; rev="4a4e642abaaa026b55f42248a7bb11945ce54607"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a4e642"; rev="4a4e642abaaa026b55f42248a7bb11945ce54607"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a4e642"; rev="4a4e642abaaa026b55f42248a7bb11945ce54607"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Picking up garbage automation moved this from To do to Done Sep 4, 2020
@jtojnar jtojnar deleted the jtojnar:drop-gst-010 branch Sep 4, 2020
@vbgl vbgl mentioned this pull request Sep 11, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.