Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intltool: fix cross-platform build #96959

Merged
merged 1 commit into from Sep 4, 2020
Merged

intltool: fix cross-platform build #96959

merged 1 commit into from Sep 4, 2020

Conversation

@kampka
Copy link
Contributor

@kampka kampka commented Sep 2, 2020

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@kampka
Copy link
Contributor Author

@kampka kampka commented Sep 2, 2020

@GrahamcOfBorg build intltool
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.intltool

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Sep 3, 2020

Maybe the replacement should be only for cross-builds?

@kampka kampka force-pushed the kampka:intltool branch from 2d34a98 to e720829 Sep 3, 2020
@kampka
Copy link
Contributor Author

@kampka kampka commented Sep 3, 2020

Maybe the replacement should be only for cross-builds?

Done

@7c6f434c 7c6f434c merged commit 7a76b1c into NixOS:staging Sep 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e720829"; rev="e7208291d2bbfded0565cda4f5d5c68fc23f83af"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e720829"; rev="e7208291d2bbfded0565cda4f5d5c68fc23f83af"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e720829"; rev="e7208291d2bbfded0565cda4f5d5c68fc23f83af"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e720829"; rev="e7208291d2bbfded0565cda4f5d5c68fc23f83af"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e720829"; rev="e7208291d2bbfded0565cda4f5d5c68fc23f83af"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e720829"; rev="e7208291d2bbfded0565cda4f5d5c68fc23f83af"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e720829"; rev="e7208291d2bbfded0565cda4f5d5c68fc23f83af"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
intltool, intltool.passthru.tests on aarch64-linux Success
Details
intltool, intltool.passthru.tests on x86_64-linux Success
Details
@kampka kampka mentioned this pull request Sep 4, 2020
4 of 10 tasks complete
@volth
Copy link
Contributor

@volth volth commented Sep 4, 2020

@GrahamcOfBorg build gnome2.libbonobo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.