openssl: fix mingw cross build by disabling patch #97

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@MarcWeber

improve exception message, comment that parallel building seems to work
but doesn't yield much faster builds

MarcWeber added some commits Aug 12, 2012
@MarcWeber MarcWeber openssl: fix mingw cross build by disabling patch
improve exception message, comment that parallel building seems to work
but doesn't yield much faster builds
66a9ed3
@MarcWeber MarcWeber fix mingw cross builds by using older compiler.
4.6.3 causes .exe files to segfault
2ff2b44
@aszlig aszlig commented on the diff Sep 11, 2012
pkgs/development/libraries/openssl/default.nix
# bundle) to be set through the environment variable
# ‘OPENSSL_X509_CERT_FILE’. This is necessary because the
# default location ($out/ssl/cert.pem) doesn't exist, and
# hardcoding something like /etc/ssl/cert.pem is impure and
# cannot be overriden per-process. For security, the
# environment variable is ignored for setuid binaries.
- ./cert-file.patch
@aszlig
aszlig Sep 11, 2012 Official Nix/Nixpkgs/NixOS member

What is the build error you get when using this patch?
It might be better to fix it, rather than to omit it in order to have consistent behavior across architectures.

@viric
Member
viric commented Dec 27, 2012

The patch can be disabled for cross-builds only, using crossAttrs. And in any case, the comment shouldn't be left intact.

@peti
Member
peti commented Feb 21, 2013

@MarcWeber, do you intend to update this patch so that it can be applied to the current master branch (and addresses the issue raised by aszlig)?

@MarcWeber

At the moment I'm not interested in cross building. If aszlig has time to update fix the patch the better.

@peti
Member
peti commented Feb 21, 2013

I'll close the issue until someone has time to revive this patch.

@peti peti closed this Feb 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment