Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svls: init at 0.1.17 #97021

Merged
merged 1 commit into from Sep 4, 2020
Merged

svls: init at 0.1.17 #97021

merged 1 commit into from Sep 4, 2020

Conversation

@trepetti
Copy link
Contributor

@trepetti trepetti commented Sep 3, 2020

Motivation for this change

Add a SystemVerilog language server protocol implementation to Nix for IDE/editor support of RTL design.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Sep 3, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Sep 3, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Sep 3, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Sep 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/292

@trepetti trepetti force-pushed the trepetti:svls branch from f9cb03d to a541196 Sep 3, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/97021
1 package built:
svls
@jonringer jonringer merged commit e3e39aa into NixOS:master Sep 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a541196"; rev="a541196268f2dade5f6be1d2601c02efd59b6881"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a541196"; rev="a541196268f2dade5f6be1d2601c02efd59b6881"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a541196"; rev="a541196268f2dade5f6be1d2601c02efd59b6881"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a541196"; rev="a541196268f2dade5f6be1d2601c02efd59b6881"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a541196"; rev="a541196268f2dade5f6be1d2601c02efd59b6881"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a541196"; rev="a541196268f2dade5f6be1d2601c02efd59b6881"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a541196"; rev="a541196268f2dade5f6be1d2601c02efd59b6881"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
svls, svls.passthru.tests on aarch64-linux Success
Details
svls, svls.passthru.tests on x86_64-linux Success
Details
@trepetti trepetti deleted the trepetti:svls branch Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.