Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.catalogue: fix expression #97050

Closed
wants to merge 1 commit into from

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 3, 2020

Motivation for this change

fix a minor boo boo from 377242d

can't do nixpkgs-review while staging is like this :(

error: while evaluating anonymous function at /home/jon/.cache/nixpkgs-review/pr-97008-2/nixpkgs/lib/meta.nix:46:54, called from undefined position:
while evaluating 'isDerivation' at /home/jon/.cache/nixpkgs-review/pr-97008-2/nixpkgs/lib/attrsets.nix:305:18, called from /home/jon/.cache/nixpkgs-review/pr-97008-2/nixpkgs/lib/meta.nix:46:62:
while evaluating 'callPackageWith' at /home/jon/.cache/nixpkgs-review/pr-97008-2/nixpkgs/lib/customisation.nix:117:35, called from /home/jon/.cache/nixpkgs-review/pr-97008-2/nixpkgs/pkgs/top-level/python-packages.nix:1037:15:
while evaluating 'makeOverridable' at /home/jon/.cache/nixpkgs-review/pr-97008-2/nixpkgs/lib/customisation.nix:67:24, called from /home/jon/.cache/nixpkgs-review/pr-97008-2/nixpkgs/lib/customisation.nix:121:8:
duplicate formal function argument 'pytestCheckHook' at /home/jon/.cache/nixpkgs-review/pr-97008-2/nixpkgs/pkgs/development/python-modules/catalogue/default.nix:5:3
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer requested a review from FRidh as a code owner Sep 3, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Sep 3, 2020

can't really do nixpkgs-review.... because it's broken until this gets merged, but:

[14:53:13] jon@nixos ~/projects/nixpkgs (fix-staging-catalogue)
$ nix build -f . --keep-going python3Packages.catalogue python37Packages.catalogue
[39 built, 3 copied (83.4 MiB), 16.2 MiB DL]
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Sep 4, 2020

appears this isn't needed after #97076

@jonringer jonringer closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.