Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.catalogue: Remove dubplicate argument pytestCheckHook #97076

Merged
merged 1 commit into from Sep 4, 2020

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 4, 2020

Motivation for this change

Fix staging evaluation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes staging evaluation.
@doronbehar doronbehar requested review from FRidh and jonringer as code owners Sep 4, 2020
@FRidh FRidh merged commit a92005b into NixOS:staging Sep 4, 2020
2 of 4 checks passed
2 of 4 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 4, 2020

duplicate of #97050 guess I should have just merged mine 9 hours ago...

@jonringer jonringer mentioned this pull request Sep 4, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.