Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: 80.0 -> 80.0.1 #97106

Merged
merged 1 commit into from Sep 6, 2020
Merged

firefox: 80.0 -> 80.0.1 #97106

merged 1 commit into from Sep 6, 2020

Conversation

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Sep 4, 2020

Motivation for this change

https://www.mozilla.org/en-US/firefox/80.0.1/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@stigtsp stigtsp marked this pull request as draft Sep 4, 2020
@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Sep 4, 2020

Waiting for local build + test

@stigtsp stigtsp requested review from vcunat and ajs124 Sep 4, 2020
@ofborg ofborg bot requested review from edolstra and andir Sep 4, 2020
@ajs124
ajs124 approved these changes Sep 4, 2020
@stigtsp stigtsp marked this pull request as ready for review Sep 4, 2020
@vcunat
vcunat approved these changes Sep 5, 2020
Copy link
Member

@vcunat vcunat left a comment

Seems to work OK for me.

@Atemu
Copy link
Member

@Atemu Atemu commented Sep 6, 2020

Result of nixpkgs-review pr 97106 1

3 packages built:
- adoptopenjdk-icedtea-web
- xulrunner (firefox-unwrapped)
- slimerjs

LGTM

@andir andir merged commit 8cf4c19 into NixOS:master Sep 6, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bbdb192"; rev="bbdb19269a55f3388328611fa582c47c017c5f2a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bbdb192"; rev="bbdb19269a55f3388328611fa582c47c017c5f2a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bbdb192"; rev="bbdb19269a55f3388328611fa582c47c017c5f2a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bbdb192"; rev="bbdb19269a55f3388328611fa582c47c017c5f2a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bbdb192"; rev="bbdb19269a55f3388328611fa582c47c017c5f2a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bbdb192"; rev="bbdb19269a55f3388328611fa582c47c017c5f2a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bbdb192"; rev="bbdb19269a55f3388328611fa582c47c017c5f2a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.