Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jackline: 2020-04-24 → 2020-09-03 #97122

Merged
merged 1 commit into from Sep 8, 2020
Merged

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Sep 4, 2020

Motivation for this change
  • Build package with dune
  • Minor UI fixes
  • IPv6 support

I also now use the required packages as inputs instead of the whole ocamlPackages set.

@vbgl How do you feel about using ocamlPackages.callPackage outside of ocamlPackages? If it's a problem, I can easily revert the change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Sep 4, 2020

@GrahamcOfBorg build jackline

@vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 5, 2020

About ocamlPackages.callPackages: besides cosmetic differences (e.g., number of arguments to the package), the main impact seems on overriding. In one case it is easy to override a single OCaml library, in the other case, it is easy to override the whole set of OCaml dependencies.

What case is more likely? Trying out with a custom version of, say, mirage-crypto or trying out with a different version of OCaml?

@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Sep 5, 2020

For the moment 4.08 is the only version jackline will work in nixpkgs (until we package the community maintained camlp4 for 4.09, 4.10, 4.11, …). On the other hand jackline, having no stable releases, generally should be built with the latest library versions (almost all of them are pinned to their latest versions currently).

So I suppose as soon as we have camlp4 for ocaml >= 4.09, ocaml is more likely to be overridden. What do you think?

@vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 7, 2020

Regarding camlp4, it might be more valuable to rewrite the parser for SASL without the stream-parser notation of camlp4…

Regarding jackline in nixpkgs, I prefer without the last change. Indeed, it would allow to write: jackline.override { inherit (ocamlPackages) tls; }. Such a nonsense is much harder to write when the package expects a single argument for a consistent set of OCaml libraries.

But you are the maintainer.

Port package to dune
@sternenseemann sternenseemann force-pushed the sternenseemann:jackline-dune branch from 5ff9e08 to 4f3310d Sep 7, 2020
@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Sep 7, 2020

Alright, I'm keeping it as it was.

Regarding camlp4: How do you feel about the community maintained version of camlp4 (https://github.com/camlp4/camlp4)? I haven't looked into it at all so far, so I can't say if it's worth packaging it at all or if it's just better to write a PR for erm_xmpp dropping the camlp4 dependency (which is planned anyways).

@vbgl vbgl merged commit d8e5c60 into NixOS:master Sep 8, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
jackline, jackline.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f3310d"; rev="4f3310dd3c50aeed432f7c3964a1a3df48b4a300"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f3310d"; rev="4f3310dd3c50aeed432f7c3964a1a3df48b4a300"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f3310d"; rev="4f3310dd3c50aeed432f7c3964a1a3df48b4a300"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f3310d"; rev="4f3310dd3c50aeed432f7c3964a1a3df48b4a300"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f3310d"; rev="4f3310dd3c50aeed432f7c3964a1a3df48b4a300"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f3310d"; rev="4f3310dd3c50aeed432f7c3964a1a3df48b4a300"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f3310d"; rev="4f3310dd3c50aeed432f7c3964a1a3df48b4a300"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
jackline, jackline.passthru.tests on x86_64-linux Success
Details
@vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 8, 2020

IMHO, it is better not to package camlp4 for recent versions of OCaml: legacy programs that depend on it can use legacy versions of OCaml (4.08 is not yet very old); maintained program should find a way out of camlp4…

In the particular case of erm_xmpp, it shouldn’t be a lot of work to rewrite the parser using menhir or some combinator library (e.g. angstrom).

@sternenseemann sternenseemann deleted the sternenseemann:jackline-dune branch Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.